You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/29 09:20:57 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4561: [WIP] Support for persistence mode in L2 networks

sureshanaparti commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r566683141



##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -1827,6 +1848,63 @@ private void orchestrateStop(final String vmUuid, final boolean cleanUpEvenIfUna
         advanceStop(vm, cleanUpEvenIfUnableToStop);
     }
 
+    private void getPersistenceMap(Map<String, Boolean> vlanToPersistenceMap, NetworkVO networkVO) {

Review comment:
       `getPersistenceMap` here doesn't return anything, _updatePersistenceMap_ might be best fit here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org