You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2015/06/20 03:22:20 UTC
Review Request 35683: LENS-493: Fix javadocs issue with java8
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35683/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-493
https://issues.apache.org/jira/browse/LENS-493
Repository: lens
Description
-------
Changes included:
1) Bump up the version of maven-jaxb2-plugin form 0.8.0 to 0.12.3. jaxb2 (0.8.0 )plugin was not following the new javadoc rules.
2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
2) Right now, many class methods are sayiig it can throw some excpetions. But it is not actually. Remove those exceptions from the method defination.
4) Removed self closed tags and added with proper open and closed tags
5) Did changes for other tags (@throws, @link ...)
Diffs
-----
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 7413a22
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 27f11bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java cd8c928
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 326a49b
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 3fc661f
lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java a3d15a7
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java e16294e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ea461ad
lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java c251e61
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 9ba136f
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java de76603
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 6078893
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fe4d926
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java b89c350
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java 96476bf
lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java 03f20ba
lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java f27ac7c
lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java 9c7be96
lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java 6696968
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java f6e88d3
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 0c5ee0a
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java db2a246
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEvent.java d74e06b
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java e0aa47c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java f7a23ab
lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 5cf1f5c
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 8d43148
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 3e0c26c
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 7b3baaa
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 2e96856
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java 87fa855
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java a28732f
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java cf735bf
lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java d360978
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b6d5fec
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 130ba3e
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java badde8c
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 15a8e06
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java b7c60bb
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java e0586e5
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 3d47c4f
pom.xml df0b766
Diff: https://reviews.apache.org/r/35683/diff/
Testing
-------
mvn site site:run is failing with some othere. Looking into
Thanks,
Raju Bairishetti
Re: Review Request 35683: LENS-493: Fix javadocs issue with java8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35683/
-----------------------------------------------------------
(Updated June 22, 2015, 5:26 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-493
https://issues.apache.org/jira/browse/LENS-493
Repository: lens
Description (updated)
-------
Changes included:
1) Bump up the version of maven-jaxb2-plugin form 0.8.0 to 0.12.3. jaxb2 (0.8.0 )plugin was not following the new javadoc rules.
2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
2) Right now, many class methods are sayiig it can throw some excpetions. But it is not actually. Remove those exceptions from the method defination.
4) Removed self closed tags and added with proper open and closed tags
5) Did changes for other tags (@throws, @link ...)
6) Commented codehaus repository in repositories section. Url is no longer accessible
Codehaus has shutdown - https://www.codehaus.org/
Diffs
-----
lens-api/src/main/resources/cube-0.1.xsd cd898cc
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 7413a22
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 27f11bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java cd8c928
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 326a49b
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 3fc661f
lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java a3d15a7
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java e16294e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ea461ad
lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java c251e61
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 17ddbfd
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 50c22f4
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 6078893
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java 0efa10d
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java b89c350
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java 96476bf
lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java 03f20ba
lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java f27ac7c
lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java 9c7be96
lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java 6696968
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java f6e88d3
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 8eba16d
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 0c5ee0a
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java db2a246
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEvent.java d74e06b
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java e0aa47c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java f7a23ab
lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 5cf1f5c
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 8d43148
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2d3a19a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 7b3baaa
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 2e96856
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java 87fa855
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java a28732f
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java cf735bf
lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java d360978
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b6d5fec
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 130ba3e
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8a1b7c8
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 15015d3
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 15a8e06
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java b7c60bb
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java e0586e5
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 3d47c4f
pom.xml a896aea
Diff: https://reviews.apache.org/r/35683/diff/
Testing
-------
mvn site site:run is failing with some othere. Looking into
Thanks,
Raju Bairishetti
Re: Review Request 35683: LENS-493: Fix javadocs issue with java8
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35683/#review88725
-----------------------------------------------------------
Ship it!
Can we fail the build on new warnings getting added on java7 as well?
- Amareshwari Sriramadasu
On June 22, 2015, 2:53 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35683/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 2:53 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-493
> https://issues.apache.org/jira/browse/LENS-493
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes included:
> 1) Bump up the version of maven-jaxb2-plugin form 0.8.0 to 0.12.3. jaxb2 (0.8.0 )plugin was not following the new javadoc rules.
>
> 2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
>
> 2) Right now, many class methods are sayiig it can throw some excpetions. But it is not actually. Remove those exceptions from the method defination.
>
> 4) Removed self closed tags and added with proper open and closed tags
>
> 5) Did changes for other tags (@throws, @link ...)
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd cd898cc
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 7413a22
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 27f11bf
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java cd8c928
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 326a49b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 3fc661f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java a3d15a7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java e16294e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ea461ad
> lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java c251e61
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 17ddbfd
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 50c22f4
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 6078893
> lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java 0efa10d
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java b89c350
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java 96476bf
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java 03f20ba
> lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java f27ac7c
> lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java 9c7be96
> lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java 6696968
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java f6e88d3
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 8eba16d
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 0c5ee0a
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java db2a246
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEvent.java d74e06b
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java e0aa47c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java f7a23ab
> lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 5cf1f5c
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 8d43148
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2d3a19a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 7b3baaa
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 2e96856
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java 87fa855
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java a28732f
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java cf735bf
> lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java d360978
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b6d5fec
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 130ba3e
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8a1b7c8
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 15015d3
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 15a8e06
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java b7c60bb
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java e0586e5
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 3d47c4f
> pom.xml a896aea
>
> Diff: https://reviews.apache.org/r/35683/diff/
>
>
> Testing
> -------
>
> mvn site site:run is failing with some othere. Looking into
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 35683: LENS-493: Fix javadocs issue with java8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35683/
-----------------------------------------------------------
(Updated June 22, 2015, 2:53 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Rebase it to master
Fixed all javadoc erros
Bugs: LENS-493
https://issues.apache.org/jira/browse/LENS-493
Repository: lens
Description
-------
Changes included:
1) Bump up the version of maven-jaxb2-plugin form 0.8.0 to 0.12.3. jaxb2 (0.8.0 )plugin was not following the new javadoc rules.
2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
2) Right now, many class methods are sayiig it can throw some excpetions. But it is not actually. Remove those exceptions from the method defination.
4) Removed self closed tags and added with proper open and closed tags
5) Did changes for other tags (@throws, @link ...)
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd cd898cc
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 7413a22
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 27f11bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java cd8c928
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 326a49b
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 3fc661f
lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java a3d15a7
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java e16294e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ea461ad
lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java c251e61
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 17ddbfd
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 50c22f4
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 6078893
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java 0efa10d
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java b89c350
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java 96476bf
lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java 03f20ba
lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java f27ac7c
lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java 9c7be96
lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java 6696968
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java f6e88d3
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 8eba16d
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 0c5ee0a
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java db2a246
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEvent.java d74e06b
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java e0aa47c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java f7a23ab
lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 5cf1f5c
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 8d43148
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2d3a19a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 7b3baaa
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 2e96856
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java 87fa855
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java a28732f
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java cf735bf
lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java d360978
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b6d5fec
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 130ba3e
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 8a1b7c8
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 15015d3
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 15a8e06
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java b7c60bb
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java e0586e5
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 3d47c4f
pom.xml a896aea
Diff: https://reviews.apache.org/r/35683/diff/
Testing
-------
mvn site site:run is failing with some othere. Looking into
Thanks,
Raju Bairishetti
Re: Review Request 35683: LENS-493: Fix javadocs issue with java8
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35683/
-----------------------------------------------------------
(Updated June 20, 2015, 5:34 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Fixed errors in cube-0.1.xsd and removed version tag from maven-site plugin
Bugs: LENS-493
https://issues.apache.org/jira/browse/LENS-493
Repository: lens
Description
-------
Changes included:
1) Bump up the version of maven-jaxb2-plugin form 0.8.0 to 0.12.3. jaxb2 (0.8.0 )plugin was not following the new javadoc rules.
2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
2) Right now, many class methods are sayiig it can throw some excpetions. But it is not actually. Remove those exceptions from the method defination.
4) Removed self closed tags and added with proper open and closed tags
5) Did changes for other tags (@throws, @link ...)
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd cd898cc
lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 7413a22
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 27f11bf
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java cd8c928
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 326a49b
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 3fc661f
lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java a3d15a7
lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java e16294e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ea461ad
lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java c251e61
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 9ba136f
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java de76603
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 6078893
lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fe4d926
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java b89c350
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java 96476bf
lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java 03f20ba
lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java f27ac7c
lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java 9c7be96
lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java 6696968
lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java f6e88d3
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 0c5ee0a
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java db2a246
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEvent.java d74e06b
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java e0aa47c
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java f7a23ab
lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 5cf1f5c
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 8d43148
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 3e0c26c
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 7b3baaa
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 2e96856
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java 87fa855
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java a28732f
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java cf735bf
lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java d360978
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b6d5fec
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 130ba3e
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java badde8c
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 15a8e06
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java b7c60bb
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java e0586e5
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 3d47c4f
pom.xml df0b766
Diff: https://reviews.apache.org/r/35683/diff/
Testing
-------
mvn site site:run is failing with some othere. Looking into
Thanks,
Raju Bairishetti
Re: Review Request 35683: LENS-493: Fix javadocs issue with java8
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35683/#review88613
-----------------------------------------------------------
>> 2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
Version will be coming from parent pom - the apache pom. Unless we require to override, let us not override.
- Amareshwari Sriramadasu
On June 20, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35683/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 1:22 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-493
> https://issues.apache.org/jira/browse/LENS-493
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes included:
> 1) Bump up the version of maven-jaxb2-plugin form 0.8.0 to 0.12.3. jaxb2 (0.8.0 )plugin was not following the new javadoc rules.
>
> 2) Not Seeing verison tag for some of the plugins. We should have version tag for all. Added a tag for maven-site.
>
> 2) Right now, many class methods are sayiig it can throw some excpetions. But it is not actually. Remove those exceptions from the method defination.
>
> 4) Removed self closed tags and added with proper open and closed tags
>
> 5) Did changes for other tags (@throws, @link ...)
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java 7413a22
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 27f11bf
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeInterface.java cd8c928
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 326a49b
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 3fc661f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java a3d15a7
> lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java e16294e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java ae65287
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 1a7b6b4
> lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ea461ad
> lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java c251e61
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 9ba136f
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java de76603
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 6078893
> lens-ml-lib/src/main/java/org/apache/lens/rdd/LensRDDClient.java fe4d926
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java b89c350
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java 96476bf
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java 03f20ba
> lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java f27ac7c
> lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java 9c7be96
> lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java 6696968
> lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java f6e88d3
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 0c5ee0a
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java db2a246
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEvent.java d74e06b
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java e0aa47c
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java f7a23ab
> lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java 5cf1f5c
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 8d43148
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 3e0c26c
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java 7b3baaa
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java 2e96856
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java 87fa855
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java a28732f
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java cf735bf
> lens-server/src/main/java/org/apache/lens/server/LensServletContextListener.java d360978
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java b6d5fec
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java 130ba3e
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 9ae0d66
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java badde8c
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java fa061ec
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 15a8e06
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java b7c60bb
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java e0586e5
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 3d47c4f
> pom.xml df0b766
>
> Diff: https://reviews.apache.org/r/35683/diff/
>
>
> Testing
> -------
>
> mvn site site:run is failing with some othere. Looking into
>
>
> Thanks,
>
> Raju Bairishetti
>
>