You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/06 09:31:30 UTC

[GitHub] [flink] wenbingshen opened a new pull request, #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

wenbingshen opened a new pull request, #20765:
URL: https://github.com/apache/flink/pull/20765

   ## What is the purpose of the change
   We'd better judge that the `timestamp` is greater than 0, we should skip setting eventTime when timestamp less than or equal to 0, otherwise the pulsar client will throw an exception.
   
   ## Brief change log
   check the `timestamp` is greater than 0
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1237912682

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b38c64c0a7b92b76334a2ed622271c0c06a9d698",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b38c64c0a7b92b76334a2ed622271c0c06a9d698",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b38c64c0a7b92b76334a2ed622271c0c06a9d698 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tisonkun commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1241474048

   Thanks for your contribution! Merging...
   
   @wenbingshen please ping me on the related backport PR. After all PRs merged, I'll close the JIRA ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wenbingshen commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1240405784

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1241466493

   @tisonkun Since this is a minor hotfix. Can you merge it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1241469176

   @wenbingshen Can you backport this PR to `release-1.15` and `release-1.16` branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1241466240

   Thanks, this PR LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wenbingshen commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1241471194

   > @wenbingshen Can you backport this PR to `release-1.15` and `release-1.16` branch?
   
   Of course. I will submit other PRs later. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wenbingshen commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1237905904

   ping @syhily PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wenbingshen commented on pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
wenbingshen commented on PR #20765:
URL: https://github.com/apache/flink/pull/20765#issuecomment-1240090035

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tisonkun merged pull request #20765: [FLINK-29207][connector/pulsar] Fix Pulsar message eventTime may be incorrectly set to a negative number

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #20765:
URL: https://github.com/apache/flink/pull/20765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org