You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/23 20:01:00 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5174: Add
EarlyTerminationException to prevent logging too many invalid error messages
Jackie-Jiang opened a new pull request #5174: Add EarlyTerminationException to prevent logging too many invalid error messages
URL: https://github.com/apache/incubator-pinot/pull/5174
When a query times out or is already satisfied, we will cancal the operator execution for early termination.
In such case, we should not log error messages as the interruptions are intentional.
In case of timeout, it will still be logged in the combine operators once, but not for each individual operators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5174: Add
EarlyTerminationException to prevent logging too many invalid error messages
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5174: Add EarlyTerminationException to prevent logging too many invalid error messages
URL: https://github.com/apache/incubator-pinot/pull/5174#issuecomment-602921484
@jackjlli It is very hard to test the logger behavior. I added some comments in CombineSlowOperatorsTest for the expected behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request
#5174: Add EarlyTerminationException to prevent logging too many invalid
error messages
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #5174: Add EarlyTerminationException to prevent logging too many invalid error messages
URL: https://github.com/apache/incubator-pinot/pull/5174#discussion_r396727816
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/CombineOperator.java
##########
@@ -117,6 +118,8 @@ public void runJob() {
}
}
blockingQueue.offer(mergedBlock);
+ } catch (EarlyTerminationException e) {
Review comment:
Could you add some unit tests/ integration tests for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5174: Add
EarlyTerminationException to prevent logging too many invalid error messages
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5174: Add EarlyTerminationException to prevent logging too many invalid error messages
URL: https://github.com/apache/incubator-pinot/pull/5174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org