You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/08/01 23:14:52 UTC

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME 

Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11104


Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................

IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME

Some developers keep multiple impala repos on their disk. Isolating
METASTORE_DB may help with switching between those repos without
reloading the data. This patch makes METASTORE_DB configurable and
default to an escaped IMPALA_HOME path.

Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11104/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................

IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME

Some developers keep multiple impala repos on their disk. Isolating
METASTORE_DB may help with switching between those repos without
reloading the data. This patch makes METASTORE_DB configurable and
default to an escaped IMPALA_HOME path.

Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
---
M bin/create-test-configuration.sh
M bin/impala-config.sh
2 files changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11104/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has restored this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 5:

It passes the check now https://jenkins.impala.io/job/gerrit-code-review-checks/255/


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 20:59:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/270/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 7
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Aug 2018 18:38:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 4:

Thanks. It's strange in that the regular build succeeded. I'm going to run clang-tidy build on my machine.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 23:43:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................

IMPALA-7383: Configurable HMS and Sentry policy DB

Some developers keep multiple impala repos on their disk. Isolating
METASTORE_DB and SENTRY_POLICY_DB may help with switching between those
repos without reloading the data. This patch makes those DB names
configurable and default to an escaped IMPALA_HOME path.

Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Reviewed-on: http://gerrit.cloudera.org:8080/11104
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/create-test-configuration.sh
M bin/impala-config.sh
M fe/src/test/resources/sentry-site.xml.template
3 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 8
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................

IMPALA-7383: Configurable HMS and Sentry policy DB

Some developers keep multiple impala repos on their disk. Isolating
METASTORE_DB and SENTRY_POLICY_DB may help with switching between those
repos without reloading the data. This patch makes those DB names
configurable and default to an escaped IMPALA_HOME path.

Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
---
M bin/create-test-configuration.sh
M bin/impala-config.sh
M fe/src/test/resources/sentry-site.xml.template
3 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11104/7
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 7
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 4:

Buried in tidylog.txt you can see that it failed because of some sentry API stuff:

[INFO] BUILD FAILURE
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project impala-frontend: Compilation failure: Compilation failure:
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryProxy.java:[27,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryProxy.java:[28,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryProxy.java:[29,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[22,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[23,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[24,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[25,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[395,15] cannot find symbol
[ERROR] symbol:   class TSentryRole
[ERROR] location: class org.apache.impala.util.SentryPolicyService
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[414,15] cannot find symbol
[ERROR] symbol:   class TSentryPrivilege
[ERROR] location: class org.apache.impala.util.SentryPolicyService
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[435,56] cannot find symbol
[ERROR] symbol:   class TSentryPrivilege
[ERROR] location: class org.apache.impala.util.SentryPolicyService
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[59,19] cannot find symbol
[ERROR] symbol:   class SentryPolicyServiceClient
[ERROR] location: class org.apache.impala.util.SentryPolicyService.SentryServiceClient
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[71,12] cannot find symbol
[ERROR] symbol:   class SentryPolicyServiceClient
[ERROR] location: class org.apache.impala.util.SentryPolicyService.SentryServiceClient
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryPolicyService.java:[89,13] cannot find symbol
[ERROR] symbol:   class SentryPolicyServiceClient
[ERROR] location: class org.apache.impala.util.SentryPolicyService.SentryServiceClient
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryUtil.java:[25,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryUtil.java:[26,52] package org.apache.sentry.provider.db.service.thrift does not exist
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryUtil.java:[50,37] cannot find symbol
[ERROR] symbol:   class SentryPolicyServiceClient
[ERROR] location: class org.apache.impala.util.SentryUtil
[ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/util/SentryUtil.java:[50,14] cannot find symbol
[ERROR] symbol:   class TSentryRole
[ERROR] location: class org.apache.impala.util.SentryUtil
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
mvn  -B install -DskipTests exited with code 0


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 22:47:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................


Patch Set 1:

Can you do similar logic for the sentry db?
https://github.com/apache/impala/blob/master/bin/create-test-configuration.sh#L109


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Aug 2018 21:29:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 4:

Not sure why this failed in the clang-tidy check: https://jenkins.impala.io/job/clang-tidy-ub1604/2482/console


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 22:43:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................

IMPALA-7383: Configurable HMS and Sentry policy DB

Some developers keep multiple impala repos on their disk. Isolating
METASTORE_DB and SENTRY_POLICY_DB may help with switching between those
repos without reloading the data. This patch makes those DB names
configurable and default to an escaped IMPALA_HOME path.

Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
---
M bin/create-test-configuration.sh
M bin/impala-config.sh
M fe/src/test/resources/sentry-site.xml.template
3 files changed, 6 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11104/6
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 6
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/210/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 21:49:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/202/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 19:50:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/226/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Aug 2018 21:28:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/146/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Aug 2018 23:49:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................

IMPALA-7383: Configurable HMS and Sentry policy DB

Some developers keep multiple impala repos on their disk. Isolating
METASTORE_DB and SENTRY_POLICY_DB may help with switching between those
repos without reloading the data. This patch makes those DB names
configurable and default to an escaped IMPALA_HOME path.

Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
---
M bin/create-test-configuration.sh
M bin/impala-config.sh
M fe/src/test/resources/sentry-site.xml.template
3 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/11104/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

This looks good to me. When this goes in, it can break people's existing dataload, so we should send out an email to dev@ to notify people and let them know that a workaround is to set METASTORE_DB=hive_impala and SENTRY_DB=sentry_policy (which can go in bin/impala-config-local.sh or their env before sourcing bin/impala-config.sh).

http://gerrit.cloudera.org:8080/#/c/11104/5/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/11104/5/bin/impala-config.sh@323
PS5, Line 323: export METASTORE_DB=\
             : ${METASTORE_DB-$(cut -c-63 <<< HMS$ESCAPED_IMPALA_HOME)}
             : export SENTRY_POLICY_DB=\
             : ${SENTRY_POLICY_DB-$(cut -c-63 <<< SP$ESCAPED_IMPALA_HOME)}
Nit: I think each of these would fit on a single line without the line break.



-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 21:10:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7383: Configurable METASTORE DB defaulting to escaped IMPALA HOME

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable METASTORE_DB defaulting to escaped IMPALA_HOME
......................................................................


Abandoned

submitted the wrong commit
-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 4:

That smells like a stale Maven cache to me, FWIW. Or you need a rebase.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Aug 2018 15:55:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 3:

> Can you do similar logic for the sentry db?
 > https://github.com/apache/impala/blob/master/bin/create-test-configuration.sh#L109

Done


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Aug 2018 21:15:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7383: Configurable HMS and Sentry policy DB

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 6:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/261/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 6
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Aug 2018 01:20:47 +0000
Gerrit-HasComments: No