You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/27 21:56:53 UTC

[GitHub] [pulsar-client-go] zzzming commented on a diff in pull request #815: [issue 814] consumer and producer reconnect failure metrics counter

zzzming commented on code in PR #815:
URL: https://github.com/apache/pulsar-client-go/pull/815#discussion_r931614381


##########
pulsar/consumer_partition.go:
##########
@@ -1155,6 +1155,9 @@ func (pc *partitionConsumer) reconnectToBroker() {
 		if maxRetry > 0 {
 			maxRetry--
 		}
+		if maxRetry == 0 || backoff.IsMaxBackoffReached() {
+			pc.metrics.ConsumersReconnectFailure.Inc()

Review Comment:
   It will also be triggered when the max backoff is reached. There is a default max. So it will reached in a minute range.
   
   What if there is temporary network failure, it recovers. Do you think if it is up to someone to consume the metrics to decide the course of action? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org