You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/10/29 23:02:17 UTC
Review Request 27351: Libprocess: Introduce enable_shared_from_this
configure check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Bugs: MESOS-2010
https://issues.apache.org/jira/browse/MESOS-2010
Repository: mesos-git
Description
-------
Introduce enable_shared_from_this to the configure check for Libprocess
Diffs
-----
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
Diff: https://reviews.apache.org/r/27351/diff/
Testing
-------
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review59053
-----------------------------------------------------------
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment100330>
can you add a comment introducing the scope of this test? (ie, check for std::enable_shared_from_this).
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment100329>
s/sharedStruct/SharedStruct/g
- Dominic Hamon
On Oct. 29, 2014, 3:02 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 3:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Nov. 10, 2014, 11:29 a.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4, line 84
> > <https://reviews.apache.org/r/27351/diff/2/?file=742017#file742017line84>
> >
> > This tests that is compiles but not whether it works as expected wrt ownership. Maybe that's ok?
that's all we're testing right now. More involved runtime tests may have to wait until we have cmake (:P)
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review60646
-----------------------------------------------------------
On Nov. 12, 2014, 11:18 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review60646
-----------------------------------------------------------
Ship it!
LGTM - have one question (inlined)
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment102015>
Comments end with period
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment102016>
This tests that is compiles but not whether it works as expected wrt ownership. Maybe that's ok?
- Niklas Nielsen
On Oct. 29, 2014, 3:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review61575
-----------------------------------------------------------
Can I get you to rebase this one as well?
- Niklas Nielsen
On Nov. 12, 2014, 11:18 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review61061
-----------------------------------------------------------
Ship it!
It would be great to document in the Mesos style guide that we want to introduce this for use anywhere we use the "pimpl" pattern.
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment102513>
s/check/Check/g
- Benjamin Hindman
On Nov. 12, 2014, 7:18 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 7:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/
-----------------------------------------------------------
(Updated Nov. 15, 2014, 2:16 a.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
Rebased.
Fixed style issues.
Bugs: MESOS-2010
https://issues.apache.org/jira/browse/MESOS-2010
Repository: mesos-git
Description
-------
Introduce enable_shared_from_this to the configure check for Libprocess
Diffs (updated)
-----
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 eebb4bd53168216ad9a6c93b3e43fb6be589c0af
Diff: https://reviews.apache.org/r/27351/diff/
Testing
-------
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 7:18 p.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
Update comment style.
Use shared_from_this() to address Nik's concern.
Bugs: MESOS-2010
https://issues.apache.org/jira/browse/MESOS-2010
Repository: mesos-git
Description
-------
Introduce enable_shared_from_this to the configure check for Libprocess
Diffs (updated)
-----
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
Diff: https://reviews.apache.org/r/27351/diff/
Testing
-------
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 7 p.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
Update comment style.
Bugs: MESOS-2010
https://issues.apache.org/jira/browse/MESOS-2010
Repository: mesos-git
Description
-------
Introduce enable_shared_from_this to the configure check for Libprocess
Diffs (updated)
-----
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
Diff: https://reviews.apache.org/r/27351/diff/
Testing
-------
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review59057
-----------------------------------------------------------
Ship it!
I don't know that it's necessary given the architecture we use and how we use shared_ptr, but i'll let Ben determine that. The configure check itself looks good.
- Dominic Hamon
On Oct. 29, 2014, 3:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 10:23 p.m.)
Review request for mesos, Benjamin Hindman and Dominic Hamon.
Changes
-------
Add comment for scope.
Rename struct.
Bugs: MESOS-2010
https://issues.apache.org/jira/browse/MESOS-2010
Repository: mesos-git
Description
-------
Introduce enable_shared_from_this to the configure check for Libprocess
Diffs (updated)
-----
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
Diff: https://reviews.apache.org/r/27351/diff/
Testing
-------
make check on gcc-4.4
make check on gcc-4.9
Thanks,
Joris Van Remoortere