You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by da...@apache.org on 2012/03/02 19:32:20 UTC

svn commit: r1296369 - /subversion/trunk/subversion/libsvn_wc/props.c

Author: danielsh
Date: Fri Mar  2 18:32:20 2012
New Revision: 1296369

URL: http://svn.apache.org/viewvc?rev=1296369&view=rev
Log:
* subversion/libsvn_wc/props.c
  (svn_wc_canonicalize_svn_prop):  Fix an off-by-one memory access.

Modified:
    subversion/trunk/subversion/libsvn_wc/props.c

Modified: subversion/trunk/subversion/libsvn_wc/props.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/props.c?rev=1296369&r1=1296368&r2=1296369&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/props.c (original)
+++ subversion/trunk/subversion/libsvn_wc/props.c Fri Mar  2 18:32:20 2012
@@ -2546,7 +2546,8 @@ svn_wc_canonicalize_svn_prop(const svn_s
            || strcmp(propname, SVN_PROP_EXTERNALS) == 0)
     {
       /* Make sure that the last line ends in a newline */
-      if (propval->data[propval->len - 1] != '\n')
+      if (propval->len == 0
+          || propval->data[propval->len - 1] != '\n')
         {
           new_value = svn_stringbuf_create_from_string(propval, pool);
           svn_stringbuf_appendbyte(new_value, '\n');