[GitHub] [geode] jujoramos opened pull request #2515: GEODE-5771: Deprecate PDX Persistence on Client

["jujoramos (GitHub)" <gi...@apache.org>]

GEODE-5771: Deprecate PDX Persistence on Client

Currently, even when set, the PDX metadata is not persisted on the
client side (to avoid dealing with problems that might arise if the
client's PDX data is inconsistent with the server).

- Methods `setPdxPersistent` and `setPdxDiskStore` from
  `ClientCacheFactory` have been deprecated.
- Attributes `persistent` and `disk-store-name` from the element `pdx`
  have been deprecated (new complex type `client-pdx-type` has been
  added to avoid messing with the pdx definition used for non-clients).
- A `warning` message will now be logged when creating the cache if we
  detect that PDX persistence has been configured for a client cache.
- Added test methods to `ClientCacheFactoryJUnitTest`, also replaced
  the usage of `junit.Assert` by `assertj`, and manual file
  manipulation/cleanup by `TemporaryFolder` rule.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2515 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos closed pull request #2515: GEODE-5771: Deprecate PDX Persistence on Client

["jujoramos (GitHub)" <gi...@apache.org>]

[ pull request closed by jujoramos ]

[ Full content available at: https://github.com/apache/geode/pull/2515 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org