You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/28 12:08:29 UTC

[GitHub] [cassandra] adelapena opened a new pull request #568: CASSANDRA-15503 3.11 Fix CQL formatting of read commands

adelapena opened a new pull request #568:
URL: https://github.com/apache/cassandra/pull/568


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] adelapena commented on pull request #568: CASSANDRA-15503 3.11 Fix CQL formatting of read commands

Posted by GitBox <gi...@apache.org>.
adelapena commented on pull request #568:
URL: https://github.com/apache/cassandra/pull/568#issuecomment-624114527


   @bereng you are right, there are some errors with how token inequalities are printed, I've fixed the arguments that are passed of `getOperator` when token ranges are used, and added a few additional dtests ([here](https://github.com/apache/cassandra-dtest/pull/67/commits/02b24c1851f9dc6912313dfae14a8aef24dab1a1)). Good catch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] bereng commented on pull request #568: CASSANDRA-15503 3.11 Fix CQL formatting of read commands

Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #568:
URL: https://github.com/apache/cassandra/pull/568#issuecomment-623971523


   @adelapena, wondering if `DataRange#getOperator(boolean, boolean)` would need a similar treatment?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org