You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Francesco Guardiani (Jira)" <ji...@apache.org> on 2022/04/12 07:44:00 UTC

[jira] [Created] (FLINK-27198) Cleanup tests testing legacy TableSink/TableSource

Francesco Guardiani created FLINK-27198:
-------------------------------------------

             Summary: Cleanup tests testing legacy TableSink/TableSource
                 Key: FLINK-27198
                 URL: https://issues.apache.org/jira/browse/FLINK-27198
             Project: Flink
          Issue Type: Sub-task
            Reporter: Francesco Guardiani


We have a lot of mock TableSink/TableSource used only for testing features of the old TableSink/TableSource stack. We should identify them and remove altogether with the tests. A non complete list:


{{Implementations of TableSink in  (25 usages found)}}
{{    Test  (14 usages found)}}
{{        flink-python_2.12  (4 usages found)}}
{{            org.apache.flink.table.legacyutils  (4 usages found)}}
{{                legacyTestingSinks.scala  (3 usages found)}}
{{                    39 private[flink] class TestAppendSink extends AppendStreamTableSink[Row] {}}
{{                    69 private[flink] class TestRetractSink extends RetractStreamTableSink[Row] {}}
{{                    95 private[flink] class TestUpsertSink(}}
{{                TestCollectionTableFactory.scala  (1 usage found)}}
{{                    168 class CollectionTableSink(val outputType: RowTypeInfo)}}
{{        flink-table-common  (1 usage found)}}
{{            org.apache.flink.table.utils  (1 usage found)}}
{{                TypeMappingUtilsTest.java  (1 usage found)}}
{{                    419 private static class TestTableSink implements TableSink<Tuple2<Boolean, Row>> {}}
{{        flink-table-planner_2.12  (9 usages found)}}
{{            org.apache.flink.table.planner.factories.utils  (1 usage found)}}
{{                TestCollectionTableFactory.scala  (1 usage found)}}
{{                    152 class CollectionTableSink(val schema: TableSchema)}}
{{            org.apache.flink.table.planner.runtime.batch.sql  (1 usage found)}}
{{                PartitionableSinkITCase.scala  (1 usage found)}}
{{                    331 private class TestSink(}}
{{            org.apache.flink.table.planner.runtime.utils  (3 usages found)}}
{{                StreamTestSink.scala  (3 usages found)}}
{{                    265 final class TestingUpsertTableSink(val keys: Array[Int], val tz: TimeZone)}}
{{                    344 final class TestingAppendTableSink(tz: TimeZone) extends AppendStreamTableSink[Row] {}}
{{                    499 final class TestingRetractTableSink(tz: TimeZone) extends RetractStreamTableSink[Row] {}}
{{            org.apache.flink.table.planner.utils  (4 usages found)}}
{{                MemoryTableSourceSinkUtil.scala  (3 usages found)}}
{{                    80 final class UnsafeMemoryAppendTableSink}}
{{                    146 final class DataTypeOutputFormatTableSink(}}
{{                    181 final class DataTypeAppendStreamTableSink(}}
{{                testTableSourceSinks.scala  (1 usage found)}}
{{                    1317 class OptionsTableSink(}}

{{Implementations of TableSource in  (31 usages found)}}
{{    Production  (8 usages found)}}
{{        flink-batch-sql-test  (1 usage found)}}
{{            org.apache.flink.sql.tests  (1 usage found)}}
{{                BatchSQLTestProgram.java  (1 usage found)}}
{{                    79 public static class GeneratorTableSource extends InputFormatTableSource<Row> {}}
{{        flink-stream-sql-test_2.12  (1 usage found)}}
{{            org.apache.flink.sql.tests  (1 usage found)}}
{{                StreamSQLTestProgram.java  (1 usage found)}}
{{                    192 public static class GeneratorTableSource}}
{{    Test  (23 usages found)}}
{{        flink-python_2.12  (1 usage found)}}
{{            org.apache.flink.table.legacyutils  (1 usage found)}}
{{                TestCollectionTableFactory.scala  (1 usage found)}}
{{                    127 class CollectionTableSource(}}
{{        flink-sql-client_2.12  (1 usage found)}}
{{            org.apache.flink.table.client.gateway.utils  (1 usage found)}}
{{                SimpleCatalogFactory.java  (1 usage found)}}
{{                    95 new StreamTableSource<Row>() {}}
{{        flink-table-api-java  (1 usage found)}}
{{            org.apache.flink.table.utils  (1 usage found)}}
{{                TableSourceMock.java  (1 usage found)}}
{{                    27 public class TableSourceMock implements TableSource<Row> {}}
{{        flink-table-common  (1 usage found)}}
{{            org.apache.flink.table.utils  (1 usage found)}}
{{                TypeMappingUtilsTest.java  (1 usage found)}}
{{                    375 private static class TestTableSource}}
{{        flink-table-planner_2.12  (19 usages found)}}
{{            org.apache.flink.table.planner.factories.utils  (1 usage found)}}
{{                TestCollectionTableFactory.scala  (1 usage found)}}
{{                    115 class CollectionTableSource(}}
{{            org.apache.flink.table.planner.plan.stream.sql.join  (2 usages found)}}
{{                LookupJoinTest.scala  (2 usages found)}}
{{                    601 class TestTemporalTable(bounded: Boolean = false)}}
{{                    667 class TestInvalidTemporalTable private(}}
{{            org.apache.flink.table.planner.runtime.utils  (1 usage found)}}
{{                InMemoryLookupableTableSource.scala  (1 usage found)}}
{{                    50 class InMemoryLookupableTableSource(}}
{{            org.apache.flink.table.planner.utils  (15 usages found)}}
{{                TableTestBase.scala  (1 usage found)}}
{{                    1372 class TestTableSource(override val isBounded: Boolean, schema: TableSchema)}}
{{                TestLegacyLimitableTableSource.scala  (1 usage found)}}
{{                    44 class TestLegacyLimitableTableSource(}}
{{                testTableSourceSinks.scala  (13 usages found)}}
{{                    205 class TestTableSourceWithTime[T](}}
{{                    316 class TestPreserveWMTableSource[T](}}
{{                    344 class TestLegacyProjectableTableSource(}}
{{                    407 class TestNestedProjectableTableSource(}}
{{                    504 class TestLegacyFilterableTableSource(}}
{{                    731 class TestInputFormatTableSource[T](}}
{{                    786 class TestDataTypeTableSource(}}
{{                    847 class TestDataTypeTableSourceWithTime(}}
{{                    926 class TestStreamTableSource(}}
{{                    977 class TestFileInputFormatTableSource(}}
{{                    1038 class TestPartitionableTableSource(}}
{{                    1209 class WithoutTimeAttributesTableSource(bounded: Boolean) extends StreamTableSource[Row] {}}
{{                    1297 class OptionsTableSource(}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)