You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/09 23:20:45 UTC

[GitHub] [kafka] jeffhuang26 opened a new pull request #8638: KAFAKA-9958: Added metrics support to Authorizer

jeffhuang26 opened a new pull request #8638:
URL: https://github.com/apache/kafka/pull/8638


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] jeffhuang26 edited a comment on pull request #8638: KAFAKA-9958: Add metrics support to Authorizer

Posted by GitBox <gi...@apache.org>.
jeffhuang26 edited a comment on pull request #8638:
URL: https://github.com/apache/kafka/pull/8638#issuecomment-626269228


   I am thinking we might move the class AuthorizerMetrics(metrics: Metrics) from AclAuthorizer.scala to the package org.kafka.server.authorizer, so that other Authorizer can reuse it? 
   Also can we define name of authorizer's metrics in one config file such as CommonClientConfigs so different Authorizers can share the same name without redefine it?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] jeffhuang26 commented on pull request #8638: KAFAKA-9958: Added metrics support to Authorizer

Posted by GitBox <gi...@apache.org>.
jeffhuang26 commented on pull request #8638:
URL: https://github.com/apache/kafka/pull/8638#issuecomment-626269228


   I am thinking we might move the class AuthorizerMetrics(metrics: Metrics) from AclAuthorizer.scala to the package org.kafka.server.authorizer, so that other Authorizer can reuse it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org