You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2026/01/20 14:05:55 UTC
[PR] Dev 0120 3 [doris]
BiteTheDDDDt opened a new pull request, #60079:
URL: https://github.com/apache/doris/pull/60079
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #60079:
URL: https://github.com/apache/doris/pull/60079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3804769332
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3778181808
# FE UT Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3806252178
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3780331439
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3779157711
# BE UT Coverage Report
Increment line coverage `13.70% (10/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/412d3ef36548b2d7816824cff2f76fad6b523b5e_412d3ef36548b2d7816824cff2f76fad6b523b5e/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/412d3ef36548b2d7816824cff2f76fad6b523b5e_412d3ef36548b2d7816824cff2f76fad6b523b5e/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.43% (19112/36454) |
| Line Coverage | 35.80% (177399/495542) |
| Region Coverage | 32.29% (137146/424785) |
| Branch Coverage | 33.20% (59330/178711) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3777017340
# FE UT Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3805945332
# BE UT Coverage Report
Increment line coverage `15.15% (10/66)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/45ee51346dbebcbd5f42a03a2030a4585e7de0b9_45ee51346dbebcbd5f42a03a2030a4585e7de0b9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/45ee51346dbebcbd5f42a03a2030a4585e7de0b9_45ee51346dbebcbd5f42a03a2030a4585e7de0b9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.71% (19253/36527) |
| Line Coverage | 36.11% (179374/496701) |
| Region Coverage | 32.58% (138841/426147) |
| Branch Coverage | 33.51% (60072/179281) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3884392909
# BE Regression && UT Coverage Report
Increment line coverage `87.88% (58/66)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.76% (25959/36176) |
| Line Coverage | 54.38% (271564/499375) |
| Region Coverage | 51.64% (224956/435642) |
| Branch Coverage | 53.24% (96890/181995) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3884478522
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3773464905
# FE UT Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_6c0f3b04cc51e39d129e6fe26e601760c3df671a/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_6c0f3b04cc51e39d129e6fe26e601760c3df671a/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3806180757
# BE Regression && UT Coverage Report
Increment line coverage `87.69% (57/65)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.52% (25606/35804) |
| Line Coverage | 54.16% (268699/496163) |
| Region Coverage | 51.89% (223459/430655) |
| Branch Coverage | 53.19% (95764/180051) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3884525352
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3777781684
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60079:
URL: https://github.com/apache/doris/pull/60079#discussion_r2708545340
##########
be/src/vec/functions/function.h:
##########
@@ -170,6 +170,8 @@ class IFunctionBase {
virtual const DataTypes& get_argument_types() const = 0;
virtual const DataTypePtr& get_return_type() const = 0;
+ virtual double execute_cost() const { return 1.0; }
+
Review Comment:
Adding execute_cost() to IFunctionBase is fine, but note that most functions appear to be wrapped by DefaultFunction (be/src/vec/functions/function.h:436+). Since DefaultFunction doesn’t override/forward execute_cost(), any per-function overrides (e.g. in IFunction implementations) won’t be observed via FunctionBasePtr. Consider forwarding execute_cost() in DefaultFunction (or otherwise ensuring the wrapper preserves the underlying function’s cost).
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:
##########
@@ -188,6 +188,12 @@ Status RowGroupReader::init(
_lazy_read_ctx.missing_columns_conjuncts.end());
RETURN_IF_ERROR(_rewrite_dict_predicates());
}
+ if (_state->query_options().enable_adjust_conjunct_order_by_cost) {
+ std::ranges::sort(_filter_conjuncts,
Review Comment:
Minor style: please keep spacing consistent with the rest of the file (`if (`).
##########
be/src/vec/exprs/vectorized_fn_call.cpp:
##########
@@ -640,5 +640,9 @@ Status VectorizedFnCall::evaluate_ann_range_search(
return Status::OK();
}
+double VectorizedFnCall::execute_cost() const {
+ return _function->execute_cost();
Review Comment:
VectorizedFnCall::execute_cost() currently returns only _function->execute_cost(), ignoring the cost of evaluating child expressions. This will underestimate cost for nested expressions (e.g. eq(add(a,b),c)) and can lead to suboptimal conjunct ordering. Consider combining the function cost with children costs (e.g. include VExpr::execute_cost() or sum children here).
```suggestion
double cost = 0.0;
if (_function != nullptr) {
cost += _function->execute_cost();
}
for (const auto& child : _children) {
if (child != nullptr) {
cost += child->execute_cost();
}
}
return cost;
```
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3087,6 +3087,9 @@ public void setDetailShapePlanNodes(String detailShapePlanNodes) {
})
public boolean enablePhraseQuerySequentialOpt = true;
+ @VariableMgr.VarAttr(name = "enable_adjust_conjunct_order_by_cost", needForward = true)
+ public boolean enableAdjustConjunctOrderByCost = true;
Review Comment:
This session variable defaults to true, meaning predicate reordering by cost will be enabled by default. Since this can change evaluation order (and potentially error/short-circuit behavior), consider defaulting it to false (similar to other cost-based reordering toggles like enableJoinReorderBasedCost).
```suggestion
public boolean enableAdjustConjunctOrderByCost = false;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3821752985
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3805107861
# FE UT Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3773070673
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3782393135
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3778028387
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/412d3ef36548b2d7816824cff2f76fad6b523b5e_412d3ef36548b2d7816824cff2f76fad6b523b5e_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/412d3ef36548b2d7816824cff2f76fad6b523b5e_412d3ef36548b2d7816824cff2f76fad6b523b5e_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.31% (1786/2252) |
| Line Coverage | 64.74% (31802/49120) |
| Region Coverage | 65.46% (15845/24207) |
| Branch Coverage | 56.06% (8424/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3882580098
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3776707756
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3773055586
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3774489957
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_6c0f3b04cc51e39d129e6fe26e601760c3df671a_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_6c0f3b04cc51e39d129e6fe26e601760c3df671a_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3782364817
# BE Regression && UT Coverage Report
Increment line coverage `91.78% (67/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.49% (25545/35733) |
| Line Coverage | 54.06% (267592/494990) |
| Region Coverage | 51.63% (221656/429292) |
| Branch Coverage | 53.04% (95199/179476) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3808820197
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3808795591
# BE Regression && UT Coverage Report
Increment line coverage `87.69% (57/65)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_45ee51346dbebcbd5f42a03a2030a4585e7de0b9_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.52% (25606/35804) |
| Line Coverage | 54.15% (268692/496163) |
| Region Coverage | 51.88% (223412/430655) |
| Branch Coverage | 53.18% (95752/180051) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3821753085
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #60079:
URL: https://github.com/apache/doris/pull/60079#discussion_r2711401868
##########
be/src/vec/functions/function.h:
##########
@@ -170,6 +170,8 @@ class IFunctionBase {
virtual const DataTypes& get_argument_types() const = 0;
virtual const DataTypePtr& get_return_type() const = 0;
+ virtual double execute_cost() const { return 1.0; }
+
Review Comment:
@copilot open a new pull request to apply changes based on [this feedback](https://github.com/apache/doris/pull/60079#discussion_r2708545340)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60079:
URL: https://github.com/apache/doris/pull/60079#discussion_r2711367308
##########
be/src/vec/exprs/vcompound_pred.h:
##########
@@ -347,6 +347,8 @@ class VCompoundPred : public VectorizedFnCall {
return Status::OK();
}
+ double execute_cost() const override { return 0.3; }
Review Comment:
`VCompoundPred::execute_cost()` returns a constant (0.3) and ignores its child expressions’ costs. Since this cost is used for conjunct reordering, dropping children costs can underestimate complex predicates (e.g., nested function calls) and lead to suboptimal ordering. Please include the children’s execute_cost in the returned value (or otherwise ensure the cost represents the whole expression tree).
```suggestion
double execute_cost() const override {
double cost = 0.3;
for (const auto& child : _children) {
if (child) {
cost += child->execute_cost();
}
}
return cost;
}
```
##########
be/src/pipeline/exec/operator.cpp:
##########
@@ -199,19 +199,21 @@ Status OperatorXBase::init(const TPlanNode& tnode, RuntimeState* /*state*/) {
_op_name = substr + "_OPERATOR";
if (tnode.__isset.vconjunct) {
- vectorized::VExprContextSPtr context;
- RETURN_IF_ERROR(vectorized::VExpr::create_expr_tree(tnode.vconjunct, context));
- _conjuncts.emplace_back(context);
+ return Status::InternalError("vconjunct is not supported yet");
} else if (tnode.__isset.conjuncts) {
Review Comment:
This change makes `OperatorXBase::init()` fail whenever `tnode.__isset.vconjunct` is true. Previously, `vconjunct` was converted into an expr tree and added to `_conjuncts`; rejecting it here is a behavioral regression that can break plan nodes emitted with `vconjunct` (even if `vconjunct.nodes` is non-empty). Please restore `vconjunct` handling (or only error if it’s truly unsupported and cannot appear), and keep behavior consistent with the existing `conjuncts` path.
##########
be/src/vec/exprs/vexpr_context.cpp:
##########
@@ -473,5 +473,9 @@ uint64_t VExprContext::get_digest(uint64_t seed) const {
return _root->get_digest(seed);
}
+double VExprContext::execute_cost() const {
Review Comment:
`VExprContext::execute_cost()` unconditionally dereferences `_root`, but the class already treats `_root == nullptr` as a valid state (e.g., `prepare_ann_range_search()` / `evaluate_ann_range_search()` early-return when `_root` is null). This can crash when cost-based sorting is enabled and a context has a null root. Please add a null check here and return an appropriate base cost (e.g., 0.0) when `_root` is null.
```suggestion
double VExprContext::execute_cost() const {
if (_root == nullptr) {
// When there is no expression root, treat the cost as a base value.
// This avoids null dereferences while keeping a deterministic cost.
return 0.0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Dev 0120 3 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3780240908
# BE Regression && UT Coverage Report
Increment line coverage `91.78% (67/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_412d3ef36548b2d7816824cff2f76fad6b523b5e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.48% (25542/35733) |
| Line Coverage | 54.05% (267539/494990) |
| Region Coverage | 51.59% (221472/429292) |
| Branch Coverage | 53.03% (95177/179476) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3884483519
# BE Regression && UT Coverage Report
Increment line coverage `87.88% (58/66)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60079_78f9eed1d2784b1fe1cdc3d798f41c2f2d447f0b_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.76% (25959/36176) |
| Line Coverage | 54.38% (271564/499375) |
| Region Coverage | 51.64% (224956/435642) |
| Branch Coverage | 53.24% (96890/181995) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](execution) support adjuct filter order by cost [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60079:
URL: https://github.com/apache/doris/pull/60079#issuecomment-3883160600
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org