You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 16:35:38 UTC
[GitHub] [arrow] westonpace opened a new pull request #10200: ARROW-12602: [R] Add BuildInfo from C++ to arrow_info
westonpace opened a new pull request #10200:
URL: https://github.com/apache/arrow/pull/10200
I had to leave C++ flags out of the print function because they were too long and messed up the output but one could still access them with `arrow_info()$build_info$cpp_compiler_flags`.
Current Output:
```
> arrow_info()
Arrow package version: 4.0.0.9000
Capabilities:
dataset TRUE
parquet TRUE
s3 TRUE
utf8proc TRUE
re2 TRUE
snappy TRUE
gzip TRUE
brotli FALSE
zstd TRUE
lz4 TRUE
lz4_frame TRUE
lzo FALSE
bz2 FALSE
jemalloc TRUE
mimalloc TRUE
Memory:
Allocator jemalloc
Current 0 bytes
Max 0 bytes
Runtime:
SIMD Level avx2
Detected SIMD Level avx2
Build:
C++ Library Version 5.0.0-SNAPSHOT
C++ Compiler GNU
C++ Compiler Version 9.3.0
Git ID 7bbfb41980d467188c96983050b06c697e0e46ee
```
Output with compiler flags left in...
```
> arrow_info()
Arrow package version: 4.0.0.9000
Capabilities:
dataset TRUE
parquet TRUE
s3 TRUE
utf8proc TRUE
re2 TRUE
snappy TRUE
gzip TRUE
brotli FALSE
zstd TRUE
lz4 TRUE
lz4_frame TRUE
lzo FALSE
bz2 FALSE
jemalloc TRUE
mimalloc TRUE
Memory:
Allocator jemalloc
Current 0 bytes
Max 0 bytes
Runtime:
SIMD Level avx2
Detected SIMD Level avx2
Build:
C++ Library Version 5.0.0-SNAPSHOT
C++ Compiler GNU
C++ Compiler Version 9.3.0
C++ Compiler Flags -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/pace/anaconda3/envs/conbench2/include -fdiagnostics-color=always -fuse-ld=gold -O3 -DNDEBUG
Git ID 7bbfb41980d467188c96983050b06c697e0e46ee
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10200: ARROW-12602: [R] Add BuildInfo from C++ to arrow_info
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10200:
URL: https://github.com/apache/arrow/pull/10200#issuecomment-829486894
https://issues.apache.org/jira/browse/ARROW-12602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10200: ARROW-12602: [R] Add BuildInfo from C++ to arrow_info
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10200:
URL: https://github.com/apache/arrow/pull/10200#discussion_r623406818
##########
File path: r/src/config.cpp
##########
@@ -21,6 +21,13 @@
#include <arrow/config.h>
+// [[arrow::export]]
+std::vector<std::string> build_info() {
+ auto info = arrow::GetBuildInfo();
+ return {info.version_string, info.compiler_id, info.compiler_version,
+ info.compiler_flags, info.git_id};
Review comment:
What happens if I'm not building from a git checkout (like from the apache source tarball or something)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #10200: ARROW-12602: [R] Add BuildInfo from C++ to arrow_info
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10200:
URL: https://github.com/apache/arrow/pull/10200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #10200: ARROW-12602: [R] Add BuildInfo from C++ to arrow_info
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #10200:
URL: https://github.com/apache/arrow/pull/10200#discussion_r623495974
##########
File path: r/src/config.cpp
##########
@@ -21,6 +21,13 @@
#include <arrow/config.h>
+// [[arrow::export]]
+std::vector<std::string> build_info() {
+ auto info = arrow::GetBuildInfo();
+ return {info.version_string, info.compiler_id, info.compiler_version,
+ info.compiler_flags, info.git_id};
Review comment:
Empty string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10200: ARROW-12602: [R] Add BuildInfo from C++ to arrow_info
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10200:
URL: https://github.com/apache/arrow/pull/10200#discussion_r624265781
##########
File path: r/R/arrow-package.R
##########
@@ -163,6 +164,13 @@ arrow_info <- function() {
runtime_info = list(
simd_level = runtimeinfo[1],
detected_simd_level = runtimeinfo[2]
+ ),
+ build_info = list(
+ cpp_version = buildinfo[1],
+ cpp_compiler = buildinfo[2],
+ cpp_compiler_version = buildinfo[3],
+ cpp_compiler_flags = buildinfo[4],
+ git_id = buildinfo[5]
Review comment:
This should prevent printing `Git ID` in the case where there is no git_id
```suggestion
# git_id is "" if not built from a git checkout
# convert that to NULL
git_id = if (nzchar(buildinfo[5])) buildinfo[5]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org