[jira] [Commented] (MJAVADOC-557) Deprecate parameter includeTransitiveDependencySources

["Ilya Kasnacheev (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464942#comment-17464942 ] 

Ilya Kasnacheev commented on MJAVADOC-557:
------------------------------------------

I think this is a bad call - there are clear use cases for transitive dependencies.

The use case as follows: you want a fat JAR and fat Javadoc for your module, which hierarchically depends on many of your modules. Currently, it is possible with includeTransitiveDependencySources and {{dependencySourceInclude=com.pany:*}} - the ones which you actually control, and hence they would not drop dependencies on random.

The currently advised approach of explicitly listing all dependencies encourages having a small number of non-hierarchial, blobby dependencies, which is an antipattert in itself.

So I suggest that maybe this parameter may be un-deprecated.

> Deprecate parameter includeTransitiveDependencySources
> ------------------------------------------------------
>
>                 Key: MJAVADOC-557
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-557
>             Project: Maven Javadoc Plugin
>          Issue Type: Task
>          Components: javadoc
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: 3.1.0
>
>
> This parameter is only useful when your code depends on transitive dependencies, which is actually a very bad practice. Your direct dependencies always have the freedom to drop libraries, which could mean that your code won't work anymore.
> Removing this parameter will simplify the code and encourage developers to not depend on transitive dependencies.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)