[GitHub] ahsanshah edited a comment on issue #5244: Single Select FIlterBox is a Must in order to make superset dashboards dynamic

[GitBox <gi...@apache.org>]

ahsanshah edited a comment on issue #5244: Single Select FIlterBox is a Must in order to make superset dashboards dynamic
URL: https://github.com/apache/incubator-superset/issues/5244#issuecomment-398978669
 
 
   Glad this is work planned up for this.  Agree that having multi does not imply you cannot do single. Power users and those that "know" the data would get it.  However, there are some valid use cases I see for both "single select" and more importantly "default".  For instance, Multi Currency where you may have metrics that need to be constrained or perhaps weird pre-aggregated location metrics such as (0-5 miles, 0-10, 0-15).  This would cause incorrect results with a multi select.  These may no be common but possible.  
   
   We are able to force a Single Select variant of FilterBox.jsx and it seems to work.  This is basically editing of ComponentWillMount with a onChange as well as logic to adjust OrigSelectedValues in the render for the actual FIilterbox.  This seems to work except that it does not force the "initial" render.
   
   The "Default" Value we are able to code also (e.g. First value from dropdown) but what we found is that this can break or affect the other slices which seems problematic.  Perhaps this would require a different approach.  Perhaps a redux related action?
   
   Will the upcoming work address Single and Default?  If so, that would be awesome.  We are exploring this but far from any sort of acceptable PR and fairly new to the tech stack.    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org