You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vidma <gi...@git.apache.org> on 2016/04/01 20:00:36 UTC

[GitHub] spark pull request: [SPARK-9372] [SQL] Filter nulls in Inner joins...

Github user vidma commented on the pull request:

    https://github.com/apache/spark/pull/9451#issuecomment-204493340
  
    @marmbrus pinging you to tag Catalyst plan rewriting guru.
    
    For current inner join PR, there's a flanky test in python, couldn't track it down yet.
    
    For more generic case (next PR), It doesn't seem to be easy not to loose table aliases, and add a randomized spraying column as extra  left join key.
    
    P.S. I'm in SF bay until Fri 8 Apr (better before Thu 9), so I could come over to chat to you guys live. 
    Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org