You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/05 07:18:43 UTC
Review Request 28741: CLOUDSTACK-8018: Improve code quality -
test_redundant_router.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28741/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8018
https://issues.apache.org/jira/browse/CLOUDSTACK-8018
Repository: cloudstack-git
Description
-------
1) Removed hard coded services data.
2) Changed variable names
3) Fixed pep8 issues
4) Now test cases read data from test_data.py
Diffs
-----
test/integration/component/maint/test_redundant_router.py 75c6122
Diff: https://reviews.apache.org/r/28741/diff/
Testing
-------
Yes. Only one test case is failing with assertion error, not related to these changes.
Thanks,
Gaurav Aradhye
Re: Review Request 28741: CLOUDSTACK-8018: Improve code quality -
test_redundant_router.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28741/#review63995
-----------------------------------------------------------
pushed to 4.5 too.
- SrikanteswaraRao Talluri
On Dec. 5, 2014, 6:18 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28741/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 6:18 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8018
> https://issues.apache.org/jira/browse/CLOUDSTACK-8018
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1) Removed hard coded services data.
> 2) Changed variable names
> 3) Fixed pep8 issues
> 4) Now test cases read data from test_data.py
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_redundant_router.py 75c6122
>
> Diff: https://reviews.apache.org/r/28741/diff/
>
>
> Testing
> -------
>
> Yes. Only one test case is failing with assertion error, not related to these changes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 28741: CLOUDSTACK-8018: Improve code quality -
test_redundant_router.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28741/#review63989
-----------------------------------------------------------
Ship it!
100e46bf4e855871c7d05dad9746b8f05c4ce046 master
Patch doesn't apply cleanly on 4.5:
Applying: CLOUDSTACK-8018: Improve code quality - test_redundant_router.py
error: patch failed: test/integration/component/maint/test_redundant_router.py:1527
error: test/integration/component/maint/test_redundant_router.py: patch does not apply
Patch failed at 0001 CLOUDSTACK-8018: Improve code quality - test_redundant_router.py
The copy of the patch that failed is found in:
/Users/talluri/asf/cloudstack/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
- SrikanteswaraRao Talluri
On Dec. 5, 2014, 6:18 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28741/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 6:18 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8018
> https://issues.apache.org/jira/browse/CLOUDSTACK-8018
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1) Removed hard coded services data.
> 2) Changed variable names
> 3) Fixed pep8 issues
> 4) Now test cases read data from test_data.py
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_redundant_router.py 75c6122
>
> Diff: https://reviews.apache.org/r/28741/diff/
>
>
> Testing
> -------
>
> Yes. Only one test case is failing with assertion error, not related to these changes.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>