[GitHub] [netbeans] neilcsmith-net commented on pull request #4785: enable branch protection for master.

[GitBox <gi...@apache.org>]

neilcsmith-net commented on PR #4785:
URL: https://github.com/apache/netbeans/pull/4785#issuecomment-1278923154

   > Not sure what it involve this means I will no more be able to change the NOTICE file date each year by direct commit to master
   
   Well, that's not necessarily a bad thing.  I mean, I usually run on all ASF checkouts `git remote set-url --push upstream DISABLED` anyway to at least make it more difficult for myself to accidentally push to the wrong place! :smile:
   
   > enable force push protection for delivery too?
   
   Please don't!  `delivery` is a transient branch that we do occasionally need to force push into a suitable state.
   
   > add reviewer requirement for master?
   
   I think that's better as a social requirement rather than a technical one - eg. anyone trusted to merge should be able to make the judgement on what level of review is required for any change.  And anyway, code can always be vetoed and/or reverted after the fact if necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists