[incubator-heron] branch bugfix/base-url created (now e4ba8f7)

[ni...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

nicknezis pushed a change to branch bugfix/base-url
in repository https://gitbox.apache.org/repos/asf/incubator-heron.git.


      at e4ba8f7  Added ability to disable base_url

This branch includes the following new commits:

     new e4ba8f7  Added ability to disable base_url

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[incubator-heron] 01/01: Added ability to disable base_url

[ni...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

nicknezis pushed a commit to branch bugfix/base-url
in repository https://gitbox.apache.org/repos/asf/incubator-heron.git

commit e4ba8f716561e7a37443af7bd25367bdeeb93dff
Author: Nicholas Nezis <ni...@gmail.com>
AuthorDate: Thu Sep 17 19:10:35 2020 +0000

    Added ability to disable base_url
---
 deploy/kubernetes/helm/templates/tools.yaml | 2 ++
 deploy/kubernetes/helm/values.yaml.template | 1 +
 2 files changed, 3 insertions(+)

diff --git a/deploy/kubernetes/helm/templates/tools.yaml b/deploy/kubernetes/helm/templates/tools.yaml
index dfa63e5..35c8e60 100644
--- a/deploy/kubernetes/helm/templates/tools.yaml
+++ b/deploy/kubernetes/helm/templates/tools.yaml
@@ -116,7 +116,9 @@ spec:
             - >-
               heron-ui
               --port=8889
+              {{- if eq .Values.heron.enable_url true }}
               --base_url={{ .Values.heron.url | default $defaultUrl }}
+              {{- end }}
         - name: heron-apiserver
           image: {{ .Values.image }}
           imagePullPolicy: {{ .Values.imagePullPolicy }}
diff --git a/deploy/kubernetes/helm/values.yaml.template b/deploy/kubernetes/helm/values.yaml.template
index 5c25b81..85008fb 100644
--- a/deploy/kubernetes/helm/values.yaml.template
+++ b/deploy/kubernetes/helm/values.yaml.template
@@ -39,6 +39,7 @@ jobReplicas: 1
 # amount of memory to provide for API server
 apiServerMemory: 512M
 heron:
+  enable_url: true
   url: ~
 # Topologies uploader
 uploader: