You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/11 07:57:14 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #34211: [SPARK-36946][PYTHON] Support time for ps.to_datetime

MaxGekk commented on a change in pull request #34211:
URL: https://github.com/apache/spark/pull/34211#discussion_r725875051



##########
File path: python/pyspark/pandas/namespace.py
##########
@@ -1638,6 +1638,21 @@ def to_datetime(
         "months": "month",
         "day": "day",
         "days": "day",
+        "hour": "h",
+        "hours": "h",
+        "minute": "m",
+        "minutes": "m",
+        "second": "s",
+        "seconds": "s",
+        "ms": "ms",
+        "millisecond": "ms",
+        "milliseconds": "ms",
+        "us": "us",
+        "microsecond": "us",
+        "microseconds": "us",
+        "ns": "ns",
+        "nanosecond": "ns",
+        "nanoseconds": "ns",

Review comment:
       Spark supports only microsecond precision. Those units don't make so much sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org