You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/21 02:38:43 UTC

[GitHub] [airflow] wc-s opened a new issue #18400: helm chart: allow each component to have different custom pod annotations

wc-s opened a new issue #18400:
URL: https://github.com/apache/airflow/issues/18400


   ### Description
   
   Currently, to inject custom annotations into airflow pods, we can use such a snippet in the `values.yaml`:
   ```
   airflowPodAnnotations:
     my-annotation: "foo"
   ```
   
   However, this will inject the annotation to the pods of all airflow components (scheduler.. worker.. etc.). There is no way to inject different annotations to different components.
   
   It would be nice to be able to inject different annotations to different components with such a `values.yaml`:
   ```
   workers:
     podAnnotations:
       my-annotation: "foo"
   
   scheduler:
     podAnnotations:
       my-annotation: "bar"
   ```
   
   
   ### Use case/motivation
   
   Generally, it's not a bad idea to make things more customizable to the chart users.
   
   Specifically for my use case, the motivation is because we are using vault sidecar to inject secrets into our airflow pods: https://www.vaultproject.io/docs/platform/k8s/injector#secrets-via-annotations
   
   And we wish to have different vault connection settings for the different pods.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #18400: helm chart: allow each component to have different custom pod annotations

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #18400:
URL: https://github.com/apache/airflow/issues/18400#issuecomment-923913337


   assigned you. Seems a good feature to have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18400: helm chart: allow each component to have different custom pod annotations

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #18400:
URL: https://github.com/apache/airflow/issues/18400#issuecomment-923554375


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #18400: helm chart: allow each component to have different custom pod annotations

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #18400:
URL: https://github.com/apache/airflow/issues/18400


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] wc-s commented on issue #18400: helm chart: allow each component to have different custom pod annotations

Posted by GitBox <gi...@apache.org>.
wc-s commented on issue #18400:
URL: https://github.com/apache/airflow/issues/18400#issuecomment-926112506


   Hey, @potiuk , I've opened a PR here: https://github.com/apache/airflow/pull/18481, with unit tests passing locally.
   
   Could you advise on how I should proceed from here? Thanks. From what I can see, I need an approval to even get the pipeline started.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org