You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/12 08:04:55 UTC
[GitHub] [superset] villebro commented on a change in pull request #18681: feat(explore): Implement metrics and columns popovers empty states
villebro commented on a change in pull request #18681:
URL: https://github.com/apache/superset/pull/18681#discussion_r805133688
##########
File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
##########
@@ -234,48 +240,80 @@ const ColumnSelectPopover = ({
allowOverflow
css={css`
height: ${POPOVER_INITIAL_HEIGHT}px;
+ width: ${UNRESIZABLE_POPOVER_WIDTH}px;
`}
>
<Tabs.TabPane key="saved" tab={t('Saved')}>
- <FormItem label={savedExpressionsLabel}>
- <StyledSelect
- ariaLabel={savedExpressionsLabel}
- value={selectedCalculatedColumn?.column_name}
- onChange={onCalculatedColumnChange}
- allowClear
- autoFocus={!selectedCalculatedColumn}
- placeholder={t('%s column(s)', calculatedColumns.length)}
- options={calculatedColumns.map(calculatedColumn => ({
- value: calculatedColumn.column_name,
- label:
- calculatedColumn.verbose_name || calculatedColumn.column_name,
- customLabel: (
- <StyledColumnOption column={calculatedColumn} showType />
- ),
- key: calculatedColumn.column_name,
- }))}
+ {calculatedColumns.length > 0 ? (
+ <FormItem label={savedExpressionsLabel}>
+ <StyledSelect
+ ariaLabel={savedExpressionsLabel}
+ value={selectedCalculatedColumn?.column_name}
+ onChange={onCalculatedColumnChange}
+ allowClear
+ autoFocus={!selectedCalculatedColumn}
+ placeholder={t('%s column(s)', calculatedColumns.length)}
+ options={calculatedColumns.map(calculatedColumn => ({
+ value: calculatedColumn.column_name,
+ label:
+ calculatedColumn.verbose_name ||
+ calculatedColumn.column_name,
+ customLabel: (
+ <StyledColumnOption column={calculatedColumn} showType />
+ ),
+ key: calculatedColumn.column_name,
+ }))}
+ />
+ </FormItem>
+ ) : (
+ <EmptyStateSmall
+ image="empty.svg"
+ title={
+ isTemporal
+ ? t('No time columns found')
+ : t('No saved expressions found')
+ }
+ description={
+ isTemporal
+ ? t(
+ 'Add calculated temporal columns to dataset in "Edit datasource" modal',
+ )
+ : t(
+ 'Add calculated columns to dataset in "Edit datasource" modal',
+ )
+ }
/>
- </FormItem>
+ )}
</Tabs.TabPane>
<Tabs.TabPane key="simple" tab={t('Simple')}>
- <FormItem label={simpleColumnsLabel}>
- <Select
- ariaLabel={simpleColumnsLabel}
- value={selectedSimpleColumn?.column_name}
- onChange={onSimpleColumnChange}
- allowClear
- autoFocus={!selectedSimpleColumn}
- placeholder={t('%s column(s)', simpleColumns.length)}
- options={simpleColumns.map(simpleColumn => ({
- value: simpleColumn.column_name,
- label: simpleColumn.verbose_name || simpleColumn.column_name,
- customLabel: (
- <StyledColumnOption column={simpleColumn} showType />
- ),
- key: simpleColumn.column_name,
- }))}
+ {isTemporal && simpleColumns.length === 0 ? (
+ <EmptyStateSmall
+ image="empty.svg"
+ title={t('No time columns found')}
Review comment:
Same here
##########
File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
##########
@@ -234,48 +240,80 @@ const ColumnSelectPopover = ({
allowOverflow
css={css`
height: ${POPOVER_INITIAL_HEIGHT}px;
+ width: ${UNRESIZABLE_POPOVER_WIDTH}px;
`}
>
<Tabs.TabPane key="saved" tab={t('Saved')}>
- <FormItem label={savedExpressionsLabel}>
- <StyledSelect
- ariaLabel={savedExpressionsLabel}
- value={selectedCalculatedColumn?.column_name}
- onChange={onCalculatedColumnChange}
- allowClear
- autoFocus={!selectedCalculatedColumn}
- placeholder={t('%s column(s)', calculatedColumns.length)}
- options={calculatedColumns.map(calculatedColumn => ({
- value: calculatedColumn.column_name,
- label:
- calculatedColumn.verbose_name || calculatedColumn.column_name,
- customLabel: (
- <StyledColumnOption column={calculatedColumn} showType />
- ),
- key: calculatedColumn.column_name,
- }))}
+ {calculatedColumns.length > 0 ? (
+ <FormItem label={savedExpressionsLabel}>
+ <StyledSelect
+ ariaLabel={savedExpressionsLabel}
+ value={selectedCalculatedColumn?.column_name}
+ onChange={onCalculatedColumnChange}
+ allowClear
+ autoFocus={!selectedCalculatedColumn}
+ placeholder={t('%s column(s)', calculatedColumns.length)}
+ options={calculatedColumns.map(calculatedColumn => ({
+ value: calculatedColumn.column_name,
+ label:
+ calculatedColumn.verbose_name ||
+ calculatedColumn.column_name,
+ customLabel: (
+ <StyledColumnOption column={calculatedColumn} showType />
+ ),
+ key: calculatedColumn.column_name,
+ }))}
+ />
+ </FormItem>
+ ) : (
+ <EmptyStateSmall
+ image="empty.svg"
+ title={
+ isTemporal
+ ? t('No time columns found')
Review comment:
nit: time column sounds like it refers to `TIME` (hh:mm:ss) as opposed to DATE/DATETIME/TIMESTAMP.
```suggestion
? t('No temporal columns found')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org