You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/08/02 05:56:29 UTC
[kudu-CR] Fix ksck-test reliance on unordered map iteration order
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3831
Change subject: Fix ksck-test reliance on unordered map iteration order
......................................................................
Fix ksck-test reliance on unordered map iteration order
TestMismatchedAssignments was relying on a specific key to come
first in an unordered map iterator. This caused the test to fail
on OS X. This alters the test so it doesn't matter which key comes
back first.
Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c
---
M src/kudu/tools/ksck-test.cc
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3831/1
--
To view, visit http://gerrit.cloudera.org:8080/3831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix ksck-test reliance on unordered map iteration order
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has abandoned this change.
Change subject: Fix ksck-test reliance on unordered map iteration order
......................................................................
Abandoned
whoops...already a review out for this
--
To view, visit http://gerrit.cloudera.org:8080/3831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix ksck-test reliance on unordered map iteration order
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Fix ksck-test reliance on unordered map iteration order
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2700/
--
To view, visit http://gerrit.cloudera.org:8080/3831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix ksck-test reliance on unordered map iteration order
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix ksck-test reliance on unordered map iteration order
......................................................................
Patch Set 1:
Hey Will. I actually put a patch up already for this here https://gerrit.cloudera.org/#/c/3734/
--
To view, visit http://gerrit.cloudera.org:8080/3831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fea40bd8f6c82d1a9147d95c18c8001713a21c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No