You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by "Srilakshmanan, Lakshman" <la...@police.vic.gov.au> on 2009/10/08 01:21:52 UTC

svn propedit svn:log

Hi All,

I encountered an issue, not sure if this is a bug, known problem or
"feature" :)

If the project url contains a "space" (http://xxxx/Common Test/Build/)
then the pre-revprop-change script fails to execute.

If I use "svnadmin setlog" all is fine.


The pre-commit script, on the other hand, executes as expected.

Any thoughts ?

Thanks
Lakshman



================================================================================================
EMAIL DISCLAIMER

This email and any attachments are confidential. They may also be subject to copyright.

If you are not an intended recipient of this email please immediately contact us by replying
to this email and then delete this email. 

You must not read, use, copy, retain, forward or disclose this email or any attachment.

We do not accept any liability arising from or in connection with unauthorised use or disclosure 
of the information contained in this email or any attachment.

We make reasonable efforts to protect against computer viruses but we do not accept liability
for any liability, loss or damage caused by any computer virus contained in this email.
================================================================================================

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2404760

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].

Re: svn propedit svn:log

Posted by David Weintraub <qa...@gmail.com>.
On Tue, Oct 13, 2009 at 11:43 PM, Srilakshmanan, Lakshman
>
> My understanding is that space is an "unsafe" character and that they need
> to be quoted with % character. There does not appear to be any official
> ruling on it.
>

That's really what I meant. You can have "%20" in a URL, but spaces are not
allowed although many browsers will execute them.

If you use <http://xxxx/Common*%20*Test/Build/> instead of <
http://xxxx/Common Test/Build/>, does the pre-revprop-change script work?

This may be an issue with the way Subversion handles spaces in URLs when
doing a revprop change. I know in programs I wrote, it wasn't unusual to
handle spaces in inputs in one area, but not doing it in another area. So,
the problem might be Subversion's.

-- 
David Weintraub
qazwart@gmail.com

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2407653

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].

RE: svn propedit svn:log

Posted by "Srilakshmanan, Lakshman" <la...@police.vic.gov.au>.
Hi David,
 
Thanks for your feedback.
 
>> I don't know what pre-revprop-change script you're using in order to
make a comment on that aspect of it.

All I have is "exit 0" in by pre-revprop-change script.
 
But I find that the pre-revprop-change script itself is not accessed. I
have tested it with debug message and no debug file is created.
When the "space" is removed from the repository name the debug file is
created with the debug message.
 
What puzzles me is that the pre-commit hook works as expected.
 
>> URLs officially should not have spaces in them
 
My understanding is that space is an "unsafe" character and that they
need to be quoted with % character. 
There does not appear to be any official ruling on it.
 
Thanks
Lakshman

________________________________

From: David Weintraub [mailto:qazwart@gmail.com] 
Sent: Tuesday, 13 October 2009 3:10 AM
To: Srilakshmanan, Lakshman
Cc: users@subversion.tigris.org
Subject: Re: svn propedit svn:log


You actually have a space in the repository's base URL which is
something you need to avoid. You may have to change your Apache
configuration to use something like http://xxxx/Common-Test or
http://xxxx/CommonTest instead of http://xxxx/Common Test. Otherwise,
you'll need to put "%20" for spaces in your URL. URLs officially should
not have spaces in them, but have them quoted with the % character.

However, that might not necessarily be the culprit. You need to take a
look at your pre-revprop-change hook to see if it is quoting the URL or
simply assuming the URL has no spaces in it. I've seen a few Subversion
utility scripts that had this issue, and putting quotation marks in
solved the problem.

I don't know what pre-revprop-change script you're using in order to
make a comment on that aspect of it.


On Wed, Oct 7, 2009 at 9:21 PM, Srilakshmanan, Lakshman
<la...@police.vic.gov.au> wrote:


	Hi All, 

	I encountered an issue, not sure if this is a bug, known problem
or "feature" :) 

	If the project url contains a "space" (http://xxxx/Common
<http://xxxx/Common>  Test/Build/) then the pre-revprop-change script
fails to execute.

	If I use "svnadmin setlog" all is fine. 


	The pre-commit script, on the other hand, executes as expected. 

	Any thoughts ? 

	Thanks 
	Lakshman 


	
========================================================================
========================
	EMAIL DISCLAIMER
	
	This email and any attachments are confidential. They may also
be subject to copyright.
	
	If you are not an intended recipient of this email please
immediately contact us by replying
	to this email and then delete this email. 
	
	You must not read, use, copy, retain, forward or disclose this
email or any attachment.
	
	We do not accept any liability arising from or in connection
with unauthorised use or disclosure 
	of the information contained in this email or any attachment.
	
	We make reasonable efforts to protect against computer viruses
but we do not accept liability
	for any liability, loss or damage caused by any computer virus
contained in this email.
	
========================================================================
========================




-- 
David Weintraub
qazwart@gmail.com


================================================================================================
EMAIL DISCLAIMER

This email and any attachments are confidential. They may also be subject to copyright.

If you are not an intended recipient of this email please immediately contact us by replying
to this email and then delete this email. 

You must not read, use, copy, retain, forward or disclose this email or any attachment.

We do not accept any liability arising from or in connection with unauthorised use or disclosure 
of the information contained in this email or any attachment.

We make reasonable efforts to protect against computer viruses but we do not accept liability
for any liability, loss or damage caused by any computer virus contained in this email.
================================================================================================

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2407393

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].

Re: svn propedit svn:log

Posted by David Weintraub <qa...@gmail.com>.
You actually have a space in the repository's base URL which is something
you need to avoid. You may have to change your Apache configuration to use
something like http://xxxx/Common-Test or http://xxxx/CommonTest instead of
http://xxxx/Common Test. Otherwise, you'll need to put "%20" for spaces in
your URL. URLs officially should not have spaces in them, but have them
quoted with the % character.

However, that might not necessarily be the culprit. You need to take a look
at your pre-revprop-change hook to see if it is quoting the URL or simply
assuming the URL has no spaces in it. I've seen a few Subversion utility
scripts that had this issue, and putting quotation marks in solved the
problem.

I don't know what pre-revprop-change script you're using in order to make a
comment on that aspect of it.

On Wed, Oct 7, 2009 at 9:21 PM, Srilakshmanan, Lakshman <
lakshman.srilakshmanan@police.vic.gov.au> wrote:

>  Hi All,
>
> I encountered an issue, not sure if this is a bug, known problem or
> "feature" :)
>
> If the project url contains a "space" (*http://xxxx/Common*<http://xxxx/Common>Test/Build/) then the pre-revprop-change script fails to execute.
>
> If I use "svnadmin setlog" all is fine.
>
> The pre-commit script, on the other hand, executes as expected.
>
> Any thoughts ?
>
> Thanks
> Lakshman
>
> ================================================================================================
> EMAIL DISCLAIMER
>
> This email and any attachments are confidential. They may also be subject to copyright.
>
> If you are not an intended recipient of this email please immediately contact us by replying
> to this email and then delete this email.
>
> You must not read, use, copy, retain, forward or disclose this email or any attachment.
>
> We do not accept any liability arising from or in connection with unauthorised use or disclosure
> of the information contained in this email or any attachment.
>
> We make reasonable efforts to protect against computer viruses but we do not accept liability
> for any liability, loss or damage caused by any computer virus contained in this email.
> ================================================================================================
>
>


-- 
David Weintraub
qazwart@gmail.com

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2406715

To unsubscribe from this discussion, e-mail: [users-unsubscribe@subversion.tigris.org].