You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vrozov (via GitHub)" <gi...@apache.org> on 2025/03/10 21:17:59 UTC

[PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

vrozov opened a new pull request, #50231:
URL: https://github.com/apache/spark/pull/50231

   ### What changes were proposed in this pull request?
   remove jar files from the Apache Spark repo and disable affected tests.
   
   
   ### Why are the changes needed?
   Apache source releases must not contained jar files.
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, there is a minor change in the Spark Connect example, otherwise PR only affects tests
   
   
   ### How was this patch tested?
   Patch disables tests affected by the removal of jars
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988324765


##########
sql/core/src/test/scala/org/apache/spark/sql/artifact/StubClassLoaderSuite.scala:
##########
@@ -101,7 +102,7 @@ class StubClassLoaderSuite extends SparkFunSuite {
 
     // Creating a new class loader will unpack the udf correctly.
     val cl2 = new ChildFirstURLClassLoader(
-      Array(udfNoAJar),
+      Array(new File(udfNoAJar).toURI.toURL),

Review Comment:
   The jar is removed, so the entire suite fails to initialize (see change on line 29).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988321649


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   It was voted on the e-mail thread I posted and there were no -1 votes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #50231: [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests
URL: https://github.com/apache/spark/pull/50231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-3040483616

   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2714762542

   @HyukjinKwon removing jars from Apache source release is a must otherwise ASF may pull out release. By voting -1 on the PR I assume that you will provide another PR shortly with removed jars and tests being enabled. cc: @dongjoon-hyun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1989810019


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   I am really sorry but do you mind sharing the link for the vote instead of discussion thread?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988228579


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   The agreement in the e-mail thread on dev@spark.apache.org I referred to is to disable affected tests. As discussed in the same e-mail thread, there are several ways to provide jars at runtime and building them is one of the option. It is outside of the scope for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1989606369


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   I refer to the [e-mail thread]( https://lists.apache.org/thread/0ro5yn6lbbpmvmqp2px3s2pf7cwljlc4) I already posted here where removal of jars proposal by @dongjoon-hyun was discussed and votes casted. Voting on the actual code changes is done on the PR and follows[ Apache voting rules](https://www.apache.org/foundation/voting.html)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2711902272

   tests files are not in the releasee. Why do we need to remove them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988259753


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   I don't think we reach the agreement there, and we did not also go for a vote. I disagree with disabling the tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2715158826

   No, I agree with removing jars but disagree with removing tests. 
   
   >  I assume that you will provide another PR shortly with removed jars and tests being enabled
   
   No, I casted my veto with a technical justification. It does not mean that I will start working on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2712147988

   Do you mind explicitly explaining the background, the discussion links, etc?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988230733


##########
sql/core/src/test/scala/org/apache/spark/sql/artifact/StubClassLoaderSuite.scala:
##########
@@ -101,7 +102,7 @@ class StubClassLoaderSuite extends SparkFunSuite {
 
     // Creating a new class loader will unpack the udf correctly.
     val cl2 = new ChildFirstURLClassLoader(
-      Array(udfNoAJar),
+      Array(new File(udfNoAJar).toURI.toURL),

Review Comment:
   There are no unrelated changes. This change is necessary otherwise test suite fails to initialize.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1989388752


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   The vote has not been concluded. Please hold until the vote is closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2753394198

   Right, I will revoke my veto, and defer to other committers as discussed in https://github.com/apache/spark/pull/50378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988187670


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   Can we create the jar during test runtime instead of simply disabling it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988188044


##########
sql/core/src/test/scala/org/apache/spark/sql/artifact/StubClassLoaderSuite.scala:
##########
@@ -101,7 +102,7 @@ class StubClassLoaderSuite extends SparkFunSuite {
 
     // Creating a new class loader will unpack the udf correctly.
     val cl2 = new ChildFirstURLClassLoader(
-      Array(udfNoAJar),
+      Array(new File(udfNoAJar).toURI.toURL),

Review Comment:
   Please remove unrelated changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2712326087

   Please put the link there, and fill the PR description with summary as guided in the template - that's the purpose of having a PR description. Otherwise people have to read the whole related threads and codes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1988259293


##########
sql/core/src/test/scala/org/apache/spark/sql/artifact/StubClassLoaderSuite.scala:
##########
@@ -101,7 +102,7 @@ class StubClassLoaderSuite extends SparkFunSuite {
 
     // Creating a new class loader will unpack the udf correctly.
     val cl2 = new ChildFirstURLClassLoader(
-      Array(udfNoAJar),
+      Array(new File(udfNoAJar).toURI.toURL),

Review Comment:
   Would you mind explaining why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2712484715

   > Please put the link there, and fill the PR description with summary as guided in the template
   
   Please see:
   
   > Why are the changes needed?
   > Apache source releases must not contained jar files.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1989388752


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   The vote has not been concluded. Please hold until the vote is closed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1989929619


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   There is no any other thread except the one I mentioned. I don't see why you expect a separate voting thread. In many cases votes are casted on the discussion thread. For example you [casted vote](https://lists.apache.org/thread/frrxhvbqtp6594k1tvs1wwmd4b2zg8h3) on the [discussion thread](https://lists.apache.org/thread/2sbdknnfn119msdq52dq5wk90jy0hc88).
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2712270036

   > Do you mind explicitly explaining the background, the discussion links, etc in PR description?
   
   I can provide link to the discussion. Replicating everything that were discussed on the e-mail thread IMO is an overkill. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2711918242

   They are. Please see https://lists.apache.org/thread/0ro5yn6lbbpmvmqp2px3s2pf7cwljlc4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50231:
URL: https://github.com/apache/spark/pull/50231#discussion_r1989391203


##########
core/src/test/scala/org/apache/spark/SparkContextSuite.scala:
##########
@@ -243,7 +243,8 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
-  test("add and list jar files") {
+  ignore("SPARK-51318: Remove `jar` files from Apache Spark repository and disable affected " +

Review Comment:
   Do you please mind sharing the link of vote? I cannot see in the dev mailing list in Spark.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2714485887

   -1 if we disable the tests. We are introducing a set of technical debt to remove the other.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-51318][TESTS] Remove `jar` files from Apache Spark repository and disable affected tests [spark]

Posted by "vrozov (via GitHub)" <gi...@apache.org>.
vrozov commented on PR #50231:
URL: https://github.com/apache/spark/pull/50231#issuecomment-2715399820

   > No, I agree with removing jars but disagree with removing tests.
   > 
   > > I assume that you will provide another PR shortly with removed jars and tests being enabled
   > 
   > No, I casted my veto with a technical justification. It does not mean that I will start working on it.
   
   If you agree that jars must be removed and they needs to be preferably removed **before** the next release goes out, somebody needs to provide code changes. As you are blocking this change even though others voted for it, the assumption is that you will provide a better solution as keeping jars is not actually even a technical debt, it is ASF legal issue.
   
   Note that the PR does not remove tests from the source code, it keeps the code, so test can be enabled back whenever there is a solution that avoids having jars in the source code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org