You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/17 21:33:14 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3585: NO-JIRA Specifying Maven Deploy Plugin as 2.4
clebertsuconic opened a new pull request #3585:
URL: https://github.com/apache/activemq-artemis/pull/3585
Using the latest (3.2.0) here will break the executables authorization for some reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3585: NO-JIRA Specifying Maven Deploy Plugin as 2.4
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3585:
URL: https://github.com/apache/activemq-artemis/pull/3585#issuecomment-843110277
I have dropped the version back to 3.1.1 in https://github.com/apache/activemq-artemis/commit/7733a76649403193e0e0e7e1a6279095fdbf426c which got things working for me.
It seems that changes in 3.2.0 around reproducible builds changed some potentially undefined behaviour. The new behaviour exists in 3.3.0 as well. It seems perhaps some of the files in the assembly are relying on the old plugin behaviour, and so coupled with the descriptor not fully defining the permissions it wants this lead to the breakage on newer versions.
I think we should try ensuring the descriptor is updated to fully reflect what it wants and then update again, but for now the slightly-older but-not-entirely-ancient plugin version seems to be doing the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic closed pull request #3585: NO-JIRA Specifying Maven Deploy Plugin as 2.4
Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3585:
URL: https://github.com/apache/activemq-artemis/pull/3585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3585: NO-JIRA Specifying Maven Deploy Plugin as 2.4
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3585:
URL: https://github.com/apache/activemq-artemis/pull/3585#issuecomment-842656317
@gemmellr the latest version of the maven deployment plugin is not reading the executor's argument on dep.xml, as a result a binary distribution would be broken.
Do you want to figure out why that happened? or can we just keep 2.4 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on pull request #3585: NO-JIRA Specifying Maven Deploy Plugin as 2.4
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #3585:
URL: https://github.com/apache/activemq-artemis/pull/3585#issuecomment-842675834
*assembly plugin, rather than deploy.
I'll look into the issue first. 2.4 is about heading for 9 years old now, we should try to stay more current so that upgrades don't need to be as wide ranging or extreme as this one was. Essentially the issue is just that I spent so long on the rest that I obviously didn't run the binary again in the end, which I should have, and have broken it along the way without noticing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org