You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2021/07/01 18:07:00 UTC
[jira] [Commented] (CASSANDRA-16777) Flaky ViewTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372982#comment-17372982 ]
Andres de la Peña commented on CASSANDRA-16777:
-----------------------------------------------
+1 to splitting {{ViewTest}}. Perhaps we could either make the tests inherit from a common super class to avoid code duplication, more or less [this way|https://github.com/adelapena/cassandra/commit/68d7d1247a24671688e030d1275710c8f4efd84e], wdyt?
It seems that several MV tests can still find server-side timeouts:
* [{{ViewPKTest.testPartitionKeyOnlyTable}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/631/workflows/d40373e0-d85a-4a7e-b3e6-0d7aa0c599c7/jobs/6183]
* [{{ViewRangesTest.testRangeTombstone}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/632/workflows/82218abb-cdb8-4445-823f-70ea3762885d/jobs/6193]
* [{{ViewRangesTest.testRangeTombstone}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/632/workflows/82218abb-cdb8-4445-823f-70ea3762885d/jobs/6194]
* [{{ViewTimesTest.ttlTest}}|https://app.circleci.com/pipelines/github/adelapena/cassandra/633/workflows/0fab87e7-26bc-457a-b742-517a04e6eca5/jobs/6198]
I think we can investigate those separately, if we are worried that they might be caused by something different than just an unusually slow CI run.
> Flaky ViewTest
> --------------
>
> Key: CASSANDRA-16777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16777
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0-rc3, 4.0, 4.0.x
>
>
> ViewTest has been [failing|https://ci-cassandra.apache.org/job/Cassandra-4.0/113/testReport/junit/org.apache.cassandra.cql3/ViewTest/testFrozenCollectionsWithComplicatedInnerType/] every now and then on the 4.0 line. Being so close to having 0 faky failures I want to scratch that itch so I propose we split it like we did with ViewComplexTest.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org