You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2013/11/13 02:39:06 UTC
Review Request 15466: [HELIX-302] fix helix version compare bug
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15466/
-----------------------------------------------------------
Review request for helix.
Bugs: HELIX-302
Repository: helix-git
Description
-------
commit b3eca30dded9d62b196083b1c89fa0acc77d49c2
Author: zzhang <zz...@apache.org>
Date: Tue Nov 12 16:40:17 2013 -0800
[HELIX-302] fix helix version compare bug
:100644 100644 9d93c97... 0e674d2... M helix-core/src/main/java/org/apache/helix/HelixConnection.java
:100644 100644 2318d20... aca2f30... M helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
:100644 100644 487c3a6... ecafbc8... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java
:100644 100644 7d6f132... 1bdc54c... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java
:000000 100644 0000000... ede570a... A helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/HelixConnection.java 9d93c97
helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java 2318d20
helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java 487c3a6
helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java 7d6f132
helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java PRE-CREATION
Diff: https://reviews.apache.org/r/15466/diff/
Testing
-------
Thanks,
Zhen Zhang
Re: Review Request 15466: [HELIX-302] fix helix version compare bug
Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15466/#review28777
-----------------------------------------------------------
Ship it!
Ship It!
- Kanak Biscuitwala
On Nov. 12, 2013, 5:39 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15466/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 5:39 p.m.)
>
>
> Review request for helix and Kanak Biscuitwala.
>
>
> Bugs: HELIX-302
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit b3eca30dded9d62b196083b1c89fa0acc77d49c2
> Author: zzhang <zz...@apache.org>
> Date: Tue Nov 12 16:40:17 2013 -0800
>
> [HELIX-302] fix helix version compare bug
>
> :100644 100644 9d93c97... 0e674d2... M helix-core/src/main/java/org/apache/helix/HelixConnection.java
> :100644 100644 2318d20... aca2f30... M helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
> :100644 100644 487c3a6... ecafbc8... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java
> :100644 100644 7d6f132... 1bdc54c... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java
> :000000 100644 0000000... ede570a... A helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/HelixConnection.java 9d93c97
> helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java 2318d20
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java 487c3a6
> helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java 7d6f132
> helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15466/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 15466: [HELIX-302] fix helix version compare bug
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15466/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 1:39 a.m.)
Review request for helix and Kanak Biscuitwala.
Bugs: HELIX-302
Repository: helix-git
Description
-------
commit b3eca30dded9d62b196083b1c89fa0acc77d49c2
Author: zzhang <zz...@apache.org>
Date: Tue Nov 12 16:40:17 2013 -0800
[HELIX-302] fix helix version compare bug
:100644 100644 9d93c97... 0e674d2... M helix-core/src/main/java/org/apache/helix/HelixConnection.java
:100644 100644 2318d20... aca2f30... M helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java
:100644 100644 487c3a6... ecafbc8... M helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java
:100644 100644 7d6f132... 1bdc54c... M helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java
:000000 100644 0000000... ede570a... A helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/HelixConnection.java 9d93c97
helix-core/src/main/java/org/apache/helix/HelixManagerProperties.java 2318d20
helix-core/src/main/java/org/apache/helix/manager/zk/HelixConnectionAdaptor.java 487c3a6
helix-core/src/main/java/org/apache/helix/manager/zk/ZkHelixConnection.java 7d6f132
helix-core/src/test/java/org/apache/helix/TestHelixVersionCompare.java PRE-CREATION
Diff: https://reviews.apache.org/r/15466/diff/
Testing
-------
Thanks,
Zhen Zhang