You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/31 21:24:26 UTC
[GitHub] [incubator-druid] clintropolis commented on a change in pull
request #7588: multi-value string column support for expressions
clintropolis commented on a change in pull request #7588: multi-value string column support for expressions
URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r289555300
##########
File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4
##########
@@ -23,13 +23,20 @@ expr : 'null' # null
| expr ('<'|'<='|'>'|'>='|'=='|'!=') expr # logicalOpExpr
| expr ('&&'|'||') expr # logicalAndOrExpr
| '(' expr ')' # nestedExpr
+ | IDENTIFIER '(' lambda ',' fnArgs ')' # applyFunctionExpr
| IDENTIFIER '(' fnArgs? ')' # functionExpr
| IDENTIFIER # identifierExpr
| DOUBLE # doubleExpr
| LONG # longExpr
| STRING # string
+ | '[' DOUBLE (','? DOUBLE)* ']' # doubleArray
+ | '[' LONG (','? LONG)* ']' # longArray
+ | '[' STRING (','? STRING)* ']' # stringArray
Review comment:
Yeah, probably should be more opinionated and require `,` to separate values, will change :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org