You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by surajpindoria <gi...@git.apache.org> on 2014/07/18 23:56:27 UTC
[GitHub] cordova-lib pull request: Breaking src into submodules
GitHub user surajpindoria opened a pull request:
https://github.com/apache/cordova-lib/pull/62
Breaking src into submodules
Split up src/cordova and src/plugman into submodules based on functionality
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/surajpindoria/cordova-lib subModulesRebase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/62.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #62
----
commit 59ad3551b1f52c251236ac532b0c61b434a0ac4c
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-08T00:00:21Z
Created Plugman "publish" submodule
commit 13c675c92be3272a25ec6db703ad28670bb78651
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-08T00:20:13Z
Created Plugman "prepare" submodule
commit a5ed25c702f0f01265d27057f779a1cd14d581d1
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-08T20:24:15Z
Created spec folders for the new submodules
commit ea2322e775db7c35c9bac89af69efb6fef1afd4f
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-08T20:38:30Z
Removed an extra folder under spec
commit 8eaa26943f402682754d33173e80bdddb53b4095
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-11T17:54:23Z
Created Plugman "install" submodule
commit 4c4c394ef69be433dd5711fba0a881172fe4334e
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-11T19:00:56Z
Created Plugman "misc" submodule
commit 51d9c6c75297e1f0f021290fca8741cdf3d656f6
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-11T21:22:03Z
Created Plugman "create" submodule
commit 5416fad73b98e26955b75530286f8606a0995f49
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-14T21:41:36Z
Create Cordova "build" submodule
commit d8d924ebb8ee6cf36e6c77ea3d0c4d7c0fe0d3e1
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-14T22:49:06Z
Created Cordova "project" submodule
commit 0ed9a95a8c2d0dce0f5f2dabd7953d8aa20f7753
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-15T00:12:34Z
Fixed tests for plugman
commit f78ed083e8d26612a229b21e8fc9c5cabdad67a9
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-15T17:57:26Z
Added another file to Cordova "project" submodule
commit 94e0cf97ba5e2f59b1792e85467727388c0cd240
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-15T22:31:37Z
Created Cordova "server" submodule
commit 02b4f0ca316b9f1fce6f97e898d321273eb99113
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-15T22:56:27Z
Create Cordova "plugins" submodule
commit 25655feb10db9564e5b9baf1f3724b9f7152021c
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-16T00:20:06Z
Created Cordova "misc" submodule
commit d4f3e0d0f568d6ea54fb83e59c5ba0ca7a1884d7
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-17T18:35:11Z
Removed duplicate files/folders
commit 034aacb74550fdc3abe8d58b4bf9d4fa3cf73757
Author: Suraj Pindoria <su...@yahoo.com>
Date: 2014-07-17T19:12:48Z
Create separate package.json files for cordova/ and plugman/
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Breaking src into submodules
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-61863908
Reposting, my other reply was only back to the dev list.
I was planning on going back and looking at this, essentially just to glean info before the re-do.
This will never rebase/merge, so it is essentially dead otherwise.
We can close it for the sake of tidiness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Breaking src into submodules
Posted by imhotep <gi...@git.apache.org>.
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-49804863
It seems like it already can't be merged cleanly because of recent commits :-(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cordova-lib pull request: Breaking src into submodules
Posted by Jesse <pu...@gmail.com>.
I was planning on going back and looking at this, essentially just to glean
info before the re-do.
This will never rebase/merge, so it is essentially dead otherwise.
We can close it for the sake of tidiness.
@purplecabbage
risingj.com
On Wed, Nov 5, 2014 at 6:46 AM, mmocny <gi...@git.apache.org> wrote:
> Github user mmocny commented on the pull request:
>
> https://github.com/apache/cordova-lib/pull/62#issuecomment-61817080
>
> Should we close this? Are we still hoping to make these changes? Did
> they land with a different set of patches?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
[GitHub] cordova-lib pull request: Breaking src into submodules
Posted by mmocny <gi...@git.apache.org>.
Github user mmocny commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-61817080
Should we close this? Are we still hoping to make these changes? Did they land with a different set of patches?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: Breaking src into submodules
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-49488330
Thanks Suraj!
I am a little worried about the impact on several outstanding pull-requests. This is a pretty big change, and will definitely cause merge issues with existing pulls, maybe even your own Tizen #47 one.
Expect this to sit and bake for a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Breaking src into submodules
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org