[GitHub] [arrow] mapleFU commented on a diff in pull request #36377: GH-36280: [Parquet][C++] parquet::arrow::FileWriter supports WriteTable in buffered mode

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #36377:
URL: https://github.com/apache/arrow/pull/36377#discussion_r1257298854


##########
cpp/src/parquet/arrow/writer.cc:
##########
@@ -356,7 +366,10 @@ class FileWriterImpl : public FileWriter {
 
   std::shared_ptr<::arrow::Schema> schema() const override { return schema_; }
 
-  Status WriteTable(const Table& table, int64_t chunk_size) override {
+  template <typename T>
+  Status WriteBuffered(const T& batch, int64_t max_row_group_length);

Review Comment:
   I guess `WriteBuffered` is better than `WriteBufferedRowGroup`, because it might write more than 1 row-groups, or not write a rowgroup?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org