general/9993: Build system deletes all CVS directories in home directory

[James LewisMoss <dr...@lewismoss.net>]

>Number:         9993
>Category:       general
>Synopsis:       Build system deletes all CVS directories in home directory
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   apache
>Arrival-Date:   Thu Feb 28 10:20:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     dres@lewismoss.net
>Release:        2.0.32 (and CVS)
>Organization:
apache
>Environment:
Debian Unstable kernel 2.4.19pre1
>Description:
The build system on install if certain variables are not set cd's to the home directory and runs find . -name CVS | xargs rm -rf.  Very bad.  And very irritating.
>How-To-Repeat:
Make sure errordir isn't set in config_vars.mk and run make install
>Fix:
Yep.  Here's a patch:
diff -ruN -x configure -x *~ -x build-tree.orig -x *.rej build-tree.orig/httpd-2.0.32/Makefile.in build-tree/httpd-2.0.32/Makefile.in
--- build-tree.orig/httpd-2.0.32/Makefile.in	Wed Jan 23 02:10:16 2002
+++ build-tree/httpd-2.0.32/Makefile.in	Thu Feb 28 12:08:24 2002
@@ -110,25 +110,25 @@
 	@test -d $(htdocs-srcdir) && (cd $(htdocs-srcdir) && cp -rp * $(htdocsdir))
 	@test -d $(manualdir) || $(MKINSTALLDIRS) $(manualdir)
 	@test -d $(top_srcdir)/docs/manual && (cd $(top_srcdir)/docs/manual && cp -rp * $(manualdir))
-	@(cd $(htdocsdir) && find . -name "CVS" -print | xargs rm -rf {} \;)
+	-(test ! -z $(htdocsdir) && cd $(htdocsdir) && find . -name "CVS" -print | xargs rm -rf {} \;)
 
 install-error:
 	@echo Installing error documents
 	@test -d $(errordir) || $(MKINSTALLDIRS) $(errordir)
 	@(cd $(top_srcdir)/docs/error && cp -rp * $(errordir))
-	@(cd $(errordir) && find . -name "CVS" -print | xargs rm -rf {} \;)
+	-(test ! -z $(errordir) && cd $(errordir) && find . -name "CVS" -print | xargs rm -rf {} \;)
 
 install-icons:
 	@echo Installing icons
 	@test -d $(iconsdir) || $(MKINSTALLDIRS) $(iconsdir)
 	@(cd $(top_srcdir)/docs/icons && cp -rp * $(iconsdir))
-	@(cd $(iconsdir) && find . -name "CVS" -print | xargs rm -rf {} \;)
+	-(test ! -z $(iconsdir) && cd $(iconsdir) && find . -name "CVS" -print | xargs rm -rf {} \;)
 
 install-cgi:
 	@echo Installing CGIs
 	@test -d $(cgidir) || $(MKINSTALLDIRS) $(cgidir)
 	@(cd $(top_srcdir)/docs/cgi-examples && cp -rp * $(cgidir))
-	@(cd $(cgidir) && find . -name "CVS" -print | xargs rm -rf {} \;)
+	-(test ! -z $(cgidir) && cd $(cgidir) && find . -name "CVS" -print | xargs rm -rf {} \;)
 
 install-other:
 	@test -d $(logfiledir) || $(MKINSTALLDIRS) $(logfiledir)
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]