You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by wgtmac <gi...@git.apache.org> on 2017/10/24 22:17:11 UTC

[GitHub] orc pull request #183: ORC-258: [C++] Incorrect Decimal constructor

GitHub user wgtmac opened a pull request:

    https://github.com/apache/orc/pull/183

    ORC-258: [C++] Incorrect Decimal constructor

    1. Fixed constructor Decimal::Decimal(const std::string& str).
    2. Added test cases to verify it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wgtmac/orc ORC-258

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit 46f9011c0fa96765ecc0e7ad343ea3bd6b22aa72
Author: Gang Wu <ga...@alibaba-inc.com>
Date:   2017-10-24T22:15:12Z

    ORC-258: [C++] Incorrect Decimal constructor
    
    1. Fixed constructor Decimal::Decimal(const std::string& str).
    2. Added test cases to verify it.

----


---

[GitHub] orc pull request #183: ORC-258: [C++] Incorrect Decimal constructor

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/183


---

[GitHub] orc issue #183: ORC-258: [C++] Incorrect Decimal constructor

Posted by majetideepak <gi...@git.apache.org>.

Github user majetideepak commented on the issue:

    https://github.com/apache/orc/pull/183
  
    @wgtmac will do. I will make another pass today and merge it. Thanks!


---

[GitHub] orc issue #183: ORC-258: [C++] Incorrect Decimal constructor

Posted by majetideepak <gi...@git.apache.org>.

Github user majetideepak commented on the issue:

    https://github.com/apache/orc/pull/183
  
    Thanks @wgtmac 


---

[GitHub] orc issue #183: ORC-258: [C++] Incorrect Decimal constructor

Posted by wgtmac <gi...@git.apache.org>.

Github user wgtmac commented on the issue:

    https://github.com/apache/orc/pull/183
  
    @majetideepak @omalley Please take a look when you have time, thanks!


---

[GitHub] orc issue #183: ORC-258: [C++] Incorrect Decimal constructor

Posted by wgtmac <gi...@git.apache.org>.

Github user wgtmac commented on the issue:

    https://github.com/apache/orc/pull/183
  
    @majetideepak Do you have time to review/merge my previous pull request for ORC-224: [https://github.com/apache/orc/pull/149](https://github.com/apache/orc/pull/149) again? You have signed off long long ago. Thanks!


---