You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/14 16:45:12 UTC

[GitHub] [apisix-dashboard] gymgym1212 opened a new pull request, #2453: fix: change "Route List" to "Routes"

gymgym1212 opened a new pull request, #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453

   Signed-off-by: Yeming Gu <ye...@gmail.com>
   
   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [x] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Replace `Route List` with `Routes`.
   
   But I'm not sure whether it's enough or not. 
   
   **Related issues**
   
   fix/resolve #2387 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1133817576

   I did the e2e test `yarn test:e2e` on my local environment. But I still got the error. Why is the dev serveUrlMap used instead of test serveUrlMap? @Baoyuantop Can you figure it out?
   ```
   [HPM] Error occurred while trying to proxy request /apisix/admin/plugin_configs from localhost:8000  
    to http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   [HPM] Error occurred while trying to proxy request /apisix/admin/plugins?all=true from localhost:8000 to  
   http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   [HPM] Error occurred while trying to proxy request /apisix/admin/plugin_configs from localhost:8000 to  
   http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1134072773

   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2453?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2453](https://codecov.io/gh/apache/apisix-dashboard/pull/2453?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7406a38) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/92f46d9d2fa8438659131eedecf9cab4c87b0f9d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92f46d9) will **decrease** coverage by `1.43%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2453      +/-   ##
   ==========================================
   - Coverage   70.27%   68.83%   -1.44%     
   ==========================================
     Files         189      131      -58     
     Lines        7492     3456    -4036     
     Branches      845      845              
   ==========================================
   - Hits         5265     2379    -2886     
   + Misses       1922     1077     -845     
   + Partials      305        0     -305     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `68.83% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | |
   | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | |
   | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | |
   | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | |
   | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
   | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
   | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
   | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
   | ... and [48 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2453/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2453?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2453?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [92f46d9...7406a38](https://codecov.io/gh/apache/apisix-dashboard/pull/2453?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1134053144

   Ok, maybe the test code is not stable enough, let me retrigger it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1143040719

   cc @guoqqqi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1133820611

   > I did the e2e test `yarn test:e2e` on my local environment. But I still got the error. Why is the dev serveUrlMap used instead of test serveUrlMap? @Baoyuantop Can you figure it out?
   > 
   > ```
   > [HPM] Error occurred while trying to proxy request /apisix/admin/plugin_configs from localhost:8000  
   >  to http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   > [HPM] Error occurred while trying to proxy request /apisix/admin/plugins?all=true from localhost:8000 to  
   > http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   > [HPM] Error occurred while trying to proxy request /apisix/admin/plugin_configs from localhost:8000 to  
   > http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   > ```
   
   My fault again... I created two front-end parts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1133669596

   Hi @Baoyuantop, I'm wondering if the ci error is caused by the dev serveUrlMap
   https://github.com/apache/apisix-dashboard/blob/227b2000296a2665dd7cac31f8671b1d34672612/web/config/defaultSettings.ts#L34-L37
   
   In my MacBook, I will get this error:
   ```
   [HPM] Error occurred while trying to proxy request /apisix/admin/labels/route from localhost:8000 to http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   [HPM] Error occurred while trying to proxy request /apisix/admin/routes?label=&page=1&page_size=10 from localhost:8000 to http://139.217.190.60 (ETIMEDOUT) (https://nodejs.org/api/errors.html#errors_common_system_errors)
   ```
   
   And the Route List is always in `loading` state, like below:
   ![image](https://user-images.githubusercontent.com/37684061/169661585-368a7e3d-d105-45b7-9ea3-0c79258dbe98.png)
   
   Therefore, this may lead to the error that the corresponding element cannot be obtained.
   ![image](https://user-images.githubusercontent.com/37684061/169661638-6ff09f54-ce1e-4339-9c1b-be883475ec74.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi merged pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
guoqqqi merged PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1133719007

   Sry, I found the e2e is running under test SERVE_ENV.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1127183977

   Need to fix a failed front-end E2E, feel free to leave a message if you need help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gymgym1212 commented on pull request #2453: fix: change "Route List" to "Routes"

Posted by GitBox <gi...@apache.org>.
gymgym1212 commented on PR #2453:
URL: https://github.com/apache/apisix-dashboard/pull/2453#issuecomment-1133824309

   Hi @Baoyuantop , I create a `test` branch in my forked repo and **the ci passed all the test**. The only difference is that I changed the action trigger branch from master to test....
   
   https://github.com/gymgym1212/apisix-dashboard/runs/6541608647?check_suite_focus=true
   
   I'm very confused about the inconsistent results. Can you help me analyze the reasons？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org