You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 21:13:44 UTC

[GitHub] [arrow] kou commented on a change in pull request #10366: [Release] Fixes to release script

kou commented on a change in pull request #10366:
URL: https://github.com/apache/arrow/pull/10366#discussion_r636474104



##########
File path: dev/release/05-binary-upload.sh
##########
@@ -128,6 +128,7 @@ docker_run \
   ./runner.sh \
   rake \
     "${rake_tasks[@]}" \
+    ARTIFACTORY_API_KEY="${ARTIFACTORY_API_KEY}" \
     APT_TARGETS=$(IFS=,; echo "${apt_targets[*]}") \

Review comment:
       Oh, thanks! I don't know why I could upload without this...
   
   Could you keep this list in alphabetical order?
   
   ```suggestion
       APT_TARGETS=$(IFS=,; echo "${apt_targets[*]}") \
       ARTIFACTORY_API_KEY="${ARTIFACTORY_API_KEY}" \
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org