You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Marcel Reutegger <mr...@adobe.com> on 2015/06/17 11:08:20 UTC

Re: svn commit: r1685189 [1/2] - in /jackrabbit/oak/trunk: oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/ oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/exter...

Hi,

this commit breaks the build. it contains a non-apache license header:

On 13/06/15 01:02, "tripod@apache.org" wrote:
>Author: tripod
>Date: Fri Jun 12 23:02:14 2015
>New Revision: 1685189
>
>URL: http://svn.apache.org/r1685189

current trunk also fails on my machine, but I don't know if those
failures are caused by above commit:

Failed tests:   
testPrincipalsFromAuthInfo(org.apache.jackrabbit.oak.security.authenticatio
n.ldap.DefaultLdapLoginModuleTest):
expected:<[org.apache.jackrabbit.oak.security.user.UserPrincipalProvider$Gr
oupPrincipal:cn=foobargroup,ou=groups,ou=system,
org.apache.jackrabbit.oak.security.user.TreeBasedPrincipal:cn=Foo
Bar,ou=users,ou=system, everyone principal]> but was:<[]>
  
testPrincipalsFromAuthInfo(org.apache.jackrabbit.oak.security.authenticatio
n.ldap.GuestTokenDefaultLdapLoginModuleTest):
expected:<[org.apache.jackrabbit.oak.security.user.UserPrincipalProvider$Gr
oupPrincipal:cn=foobargroup,ou=groups,ou=system,
org.apache.jackrabbit.oak.security.user.TreeBasedPrincipal:cn=Foo
Bar,ou=users,ou=system, everyone principal]> but was:<[]>
  
testPrincipalsFromAuthInfo(org.apache.jackrabbit.oak.security.authenticatio
n.ldap.TokenDefaultLdapLoginModuleTest):
expected:<[org.apache.jackrabbit.oak.security.user.UserPrincipalProvider$Gr
oupPrincipal:cn=foobargroup,ou=groups,ou=system,
org.apache.jackrabbit.oak.security.user.TreeBasedPrincipal:cn=Foo
Bar,ou=users,ou=system, everyone principal]> but was:<[]>

Regards

 Marcel


Re: svn commit: r1685189 [1/2] - in /jackrabbit/oak/trunk: oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/ oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/exter...

Posted by Tobias Bocanegra <tr...@apache.org>.
thanks for spotting....
I'll fix it asap.

regards, toby

On Wed, Jun 17, 2015 at 2:08 AM, Marcel Reutegger <mr...@adobe.com> wrote:
> Hi,
>
> this commit breaks the build. it contains a non-apache license header:
>
> On 13/06/15 01:02, "tripod@apache.org" wrote:
>>Author: tripod
>>Date: Fri Jun 12 23:02:14 2015
>>New Revision: 1685189
>>
>>URL: http://svn.apache.org/r1685189
>
> current trunk also fails on my machine, but I don't know if those
> failures are caused by above commit:
>
> Failed tests:
> testPrincipalsFromAuthInfo(org.apache.jackrabbit.oak.security.authenticatio
> n.ldap.DefaultLdapLoginModuleTest):
> expected:<[org.apache.jackrabbit.oak.security.user.UserPrincipalProvider$Gr
> oupPrincipal:cn=foobargroup,ou=groups,ou=system,
> org.apache.jackrabbit.oak.security.user.TreeBasedPrincipal:cn=Foo
> Bar,ou=users,ou=system, everyone principal]> but was:<[]>
>
> testPrincipalsFromAuthInfo(org.apache.jackrabbit.oak.security.authenticatio
> n.ldap.GuestTokenDefaultLdapLoginModuleTest):
> expected:<[org.apache.jackrabbit.oak.security.user.UserPrincipalProvider$Gr
> oupPrincipal:cn=foobargroup,ou=groups,ou=system,
> org.apache.jackrabbit.oak.security.user.TreeBasedPrincipal:cn=Foo
> Bar,ou=users,ou=system, everyone principal]> but was:<[]>
>
> testPrincipalsFromAuthInfo(org.apache.jackrabbit.oak.security.authenticatio
> n.ldap.TokenDefaultLdapLoginModuleTest):
> expected:<[org.apache.jackrabbit.oak.security.user.UserPrincipalProvider$Gr
> oupPrincipal:cn=foobargroup,ou=groups,ou=system,
> org.apache.jackrabbit.oak.security.user.TreeBasedPrincipal:cn=Foo
> Bar,ou=users,ou=system, everyone principal]> but was:<[]>
>
> Regards
>
>  Marcel
>