You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/11/07 06:14:12 UTC
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11898
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
De-flake sentry_client-test and sentry_authz_provider-test
Currently, sentry_client-test and sentry_authz_provider-test often fail
with 'BindException: Address already in use'. Because Sentry uses a
default port number '8038' if 'sentry.service.server.rpc-port'
is not set.
This commit sets this configuration with port 0 to ensure the mini Sentry
service can always find a free port to bound to. When running
sentry_client-test and sentry_authz_provider-test in parallel on the
same machine: before the change, one of the tests failed with
BindException; after the change, both tests passed without any errors.
Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
---
M src/kudu/sentry/mini_sentry.cc
M src/kudu/sentry/mini_sentry.h
2 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/98/11898/1
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG@14
PS1, Line 14: This commit sets this configuration with port 0 to ensure the mini Sentry
: service can always find a free port to bound to. When running
: sentry_client-test and sentry_authz_provider-test in parallel on the
: same machine: before the change, one of the tests failed with
: BindException; after the change, both tests passed without any errors.
Would it make sense to have a test that instantiates two MiniSentry instances? Would such a test have caught this?
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 17:19:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG@14
PS1, Line 14: This commit sets this configuration with port 0 to ensure the mini Sentry
: service can always find a free port to bound to. When running
: sentry_client-test and sentry_authz_provider-test in parallel on the
: same machine: before the change, one of the tests failed with
: BindException; after the change, both tests passed without any errors.
> Right, I meant as a regression test, but I don't feel strongly that it's ne
I also don't feel strong neither, as the purpose of such test is only to ensure there wouldn't be any issues for running other tests.
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 20:18:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 1: Verified+1
Unrelated flaky DefaultSourceTest.
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 07:06:40 +0000
Gerrit-HasComments: No
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 15:42:21 +0000
Gerrit-HasComments: No
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG@14
PS1, Line 14: This commit sets this configuration with port 0 to ensure the mini Sentry
: service can always find a free port to bound to. When running
: sentry_client-test and sentry_authz_provider-test in parallel on the
: same machine: before the change, one of the tests failed with
: BindException; after the change, both tests passed without any errors.
> Hmm, after use port 0 I think this issue will not come back. But if you thi
Right, I meant as a regression test, but I don't feel strongly that it's needed.
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 17:52:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 17:30:29 +0000
Gerrit-HasComments: No
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11898/1//COMMIT_MSG@14
PS1, Line 14: This commit sets this configuration with port 0 to ensure the mini Sentry
: service can always find a free port to bound to. When running
: sentry_client-test and sentry_authz_provider-test in parallel on the
: same machine: before the change, one of the tests failed with
: BindException; after the change, both tests passed without any errors.
> Would it make sense to have a test that instantiates two MiniSentry instanc
Hmm, after use port 0 I think this issue will not come back. But if you think this is necessary, I can add such test in a follow up patch.
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Nov 2018 17:46:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11898 )
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
De-flake sentry_client-test and sentry_authz_provider-test
Currently, sentry_client-test and sentry_authz_provider-test often fail
with 'BindException: Address already in use'. Because Sentry uses a
default port number '8038' if 'sentry.service.server.rpc-port'
is not set.
This commit sets this configuration with port 0 to ensure the mini Sentry
service can always find a free port to bound to. When running
sentry_client-test and sentry_authz_provider-test in parallel on the
same machine: before the change, one of the tests failed with
BindException; after the change, both tests passed without any errors.
Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Reviewed-on: http://gerrit.cloudera.org:8080/11898
Tested-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/sentry/mini_sentry.cc
M src/kudu/sentry/mini_sentry.h
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Hao Hao: Verified
Grant Henke: Looks good to me, approved
Andrew Wong: Looks good to me, approved
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] De-flake sentry client-test and sentry authz provider-test
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed a vote on this change.
Change subject: De-flake sentry_client-test and sentry_authz_provider-test
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0e30ce88b7c2ab4afe451c50e13ef739237709e0
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)