You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@deltaspike.apache.org by Christian Beikov <ch...@gmail.com> on 2018/03/01 08:30:21 UTC
Introduce Pageable in DeltaSpike Data analogous to Spring Data
Hey,
I was wondering if there would be interest in introducing a Pageable
interface analogous to what Spring Data has or if the DeltaSpike answer
to this is the QueryResult interface.
Being able to pass in the pagination configuration as parameter has the
advantage that one could e.g. write a JAX-RS RequestBodyReader for
constructing the object from various sources. Without such a Pageable
interface, users would have to map the request parameters manually to
the respective operations in a QueryResult which is quite repetitive and
not really allows for extensions. I implemented an extension for Spring
Data and Spring MVC that adds support for keyset pagination which is
made easily possible because I can just subclasss the Pageable interface
of Spring Data and handle the deserialization in a custom
MethodArgumentResolver. I'd like to do the same for DeltaSpike Data with
JAX-RS which forces me to create my own Pageable interface.
Since I just read that Mark is proposing to set the required Java base
version to 8, I was wondering if this means there will be a 2.0 release
that is Java 8ified. If so, I would like to propose to add this Pageable
stuff to DeltaSpike Data 2.0.
Comments, thoughts? :)
--
Mit freundlichen Grüßen,
------------------------------------------------------------------------
*Christian Beikov*
Re: Introduce Pageable in DeltaSpike Data analogous to Spring Data
Posted by Gerhard Petracek <gp...@apache.org>.
hi @ all,
fyi:
in our irc-channel the main (tech.) argument about requiring java 8 as a
baseline before ds2 was about default methods.
however, there wasn't a clear consensus about using default methods in our
api/spi -> maybe we should discuss those topics first.
regards,
gerhard
2018-03-01 12:37 GMT+01:00 Thomas Andraschko <an...@gmail.com>:
> Thats what we currently have: DS1.9 = Java8 && JavaEE7
> We can such Java8 improvements in DS1.9, there is no need to wait for 2.0.
>
> 2018-03-01 12:29 GMT+01:00 Ondrej Mihályi <on...@gmail.com>:
>
> > +1 to EE7 and Java 8 as baseline. There are even no production ready EE 8
> > servers yet, although Payara and some others are very close.
> >
> > Ondro
> >
> > Dňa 1. 3. 2018 10:22 AM používateľ "Christian Beikov" <
> > christian.beikov@gmail.com> napísal:
> >
> > > Ok great, I'll look into this.
> > >
> > > As for JEE8, I'd prefer to keep JEE7 as the baseline for 2.0 as JEE8
> > > doesn't seem to be very widespread yet.
> > >
> > >
> > > Mit freundlichen Grüßen,
> > > ------------------------------------------------------------
> ------------
> > > *Christian Beikov*
> > > Am 01.03.2018 um 10:16 schrieb Thomas Andraschko:
> > >
> > >> Feel free to work on patch! ;)
> > >>
> > >> And yes, probably DS2.0 will need some redesigns or enhancements based
> > on
> > >> Java8.
> > >> We also already talked about if DS2.0 should only target JEE8, to do a
> > >> little cleanup on the project.
> > >> I think we will need to start a new discussion, but don't know if
> anyone
> > >> has time until TomEE8 is ready ;)
> > >>
> > >> 2018-03-01 9:30 GMT+01:00 Christian Beikov <
> christian.beikov@gmail.com
> > >:
> > >>
> > >> Hey,
> > >>>
> > >>> I was wondering if there would be interest in introducing a Pageable
> > >>> interface analogous to what Spring Data has or if the DeltaSpike
> answer
> > >>> to
> > >>> this is the QueryResult interface.
> > >>>
> > >>> Being able to pass in the pagination configuration as parameter has
> the
> > >>> advantage that one could e.g. write a JAX-RS RequestBodyReader for
> > >>> constructing the object from various sources. Without such a Pageable
> > >>> interface, users would have to map the request parameters manually to
> > the
> > >>> respective operations in a QueryResult which is quite repetitive and
> > not
> > >>> really allows for extensions. I implemented an extension for Spring
> > Data
> > >>> and Spring MVC that adds support for keyset pagination which is made
> > >>> easily
> > >>> possible because I can just subclasss the Pageable interface of
> Spring
> > >>> Data
> > >>> and handle the deserialization in a custom MethodArgumentResolver.
> I'd
> > >>> like
> > >>> to do the same for DeltaSpike Data with JAX-RS which forces me to
> > create
> > >>> my
> > >>> own Pageable interface.
> > >>>
> > >>> Since I just read that Mark is proposing to set the required Java
> base
> > >>> version to 8, I was wondering if this means there will be a 2.0
> release
> > >>> that is Java 8ified. If so, I would like to propose to add this
> > Pageable
> > >>> stuff to DeltaSpike Data 2.0.
> > >>>
> > >>> Comments, thoughts? :)
> > >>>
> > >>> --
> > >>>
> > >>> Mit freundlichen Grüßen,
> > >>> ------------------------------------------------------------
> > ------------
> > >>> *Christian Beikov*
> > >>>
> > >>>
> > >
> >
>
Re: Introduce Pageable in DeltaSpike Data analogous to Spring Data
Posted by Thomas Andraschko <an...@gmail.com>.
Thats what we currently have: DS1.9 = Java8 && JavaEE7
We can such Java8 improvements in DS1.9, there is no need to wait for 2.0.
2018-03-01 12:29 GMT+01:00 Ondrej Mihályi <on...@gmail.com>:
> +1 to EE7 and Java 8 as baseline. There are even no production ready EE 8
> servers yet, although Payara and some others are very close.
>
> Ondro
>
> Dňa 1. 3. 2018 10:22 AM používateľ "Christian Beikov" <
> christian.beikov@gmail.com> napísal:
>
> > Ok great, I'll look into this.
> >
> > As for JEE8, I'd prefer to keep JEE7 as the baseline for 2.0 as JEE8
> > doesn't seem to be very widespread yet.
> >
> >
> > Mit freundlichen Grüßen,
> > ------------------------------------------------------------------------
> > *Christian Beikov*
> > Am 01.03.2018 um 10:16 schrieb Thomas Andraschko:
> >
> >> Feel free to work on patch! ;)
> >>
> >> And yes, probably DS2.0 will need some redesigns or enhancements based
> on
> >> Java8.
> >> We also already talked about if DS2.0 should only target JEE8, to do a
> >> little cleanup on the project.
> >> I think we will need to start a new discussion, but don't know if anyone
> >> has time until TomEE8 is ready ;)
> >>
> >> 2018-03-01 9:30 GMT+01:00 Christian Beikov <christian.beikov@gmail.com
> >:
> >>
> >> Hey,
> >>>
> >>> I was wondering if there would be interest in introducing a Pageable
> >>> interface analogous to what Spring Data has or if the DeltaSpike answer
> >>> to
> >>> this is the QueryResult interface.
> >>>
> >>> Being able to pass in the pagination configuration as parameter has the
> >>> advantage that one could e.g. write a JAX-RS RequestBodyReader for
> >>> constructing the object from various sources. Without such a Pageable
> >>> interface, users would have to map the request parameters manually to
> the
> >>> respective operations in a QueryResult which is quite repetitive and
> not
> >>> really allows for extensions. I implemented an extension for Spring
> Data
> >>> and Spring MVC that adds support for keyset pagination which is made
> >>> easily
> >>> possible because I can just subclasss the Pageable interface of Spring
> >>> Data
> >>> and handle the deserialization in a custom MethodArgumentResolver. I'd
> >>> like
> >>> to do the same for DeltaSpike Data with JAX-RS which forces me to
> create
> >>> my
> >>> own Pageable interface.
> >>>
> >>> Since I just read that Mark is proposing to set the required Java base
> >>> version to 8, I was wondering if this means there will be a 2.0 release
> >>> that is Java 8ified. If so, I would like to propose to add this
> Pageable
> >>> stuff to DeltaSpike Data 2.0.
> >>>
> >>> Comments, thoughts? :)
> >>>
> >>> --
> >>>
> >>> Mit freundlichen Grüßen,
> >>> ------------------------------------------------------------
> ------------
> >>> *Christian Beikov*
> >>>
> >>>
> >
>
Re: Introduce Pageable in DeltaSpike Data analogous to Spring Data
Posted by Ondrej Mihályi <on...@gmail.com>.
+1 to EE7 and Java 8 as baseline. There are even no production ready EE 8
servers yet, although Payara and some others are very close.
Ondro
Dňa 1. 3. 2018 10:22 AM používateľ "Christian Beikov" <
christian.beikov@gmail.com> napísal:
> Ok great, I'll look into this.
>
> As for JEE8, I'd prefer to keep JEE7 as the baseline for 2.0 as JEE8
> doesn't seem to be very widespread yet.
>
>
> Mit freundlichen Grüßen,
> ------------------------------------------------------------------------
> *Christian Beikov*
> Am 01.03.2018 um 10:16 schrieb Thomas Andraschko:
>
>> Feel free to work on patch! ;)
>>
>> And yes, probably DS2.0 will need some redesigns or enhancements based on
>> Java8.
>> We also already talked about if DS2.0 should only target JEE8, to do a
>> little cleanup on the project.
>> I think we will need to start a new discussion, but don't know if anyone
>> has time until TomEE8 is ready ;)
>>
>> 2018-03-01 9:30 GMT+01:00 Christian Beikov <ch...@gmail.com>:
>>
>> Hey,
>>>
>>> I was wondering if there would be interest in introducing a Pageable
>>> interface analogous to what Spring Data has or if the DeltaSpike answer
>>> to
>>> this is the QueryResult interface.
>>>
>>> Being able to pass in the pagination configuration as parameter has the
>>> advantage that one could e.g. write a JAX-RS RequestBodyReader for
>>> constructing the object from various sources. Without such a Pageable
>>> interface, users would have to map the request parameters manually to the
>>> respective operations in a QueryResult which is quite repetitive and not
>>> really allows for extensions. I implemented an extension for Spring Data
>>> and Spring MVC that adds support for keyset pagination which is made
>>> easily
>>> possible because I can just subclasss the Pageable interface of Spring
>>> Data
>>> and handle the deserialization in a custom MethodArgumentResolver. I'd
>>> like
>>> to do the same for DeltaSpike Data with JAX-RS which forces me to create
>>> my
>>> own Pageable interface.
>>>
>>> Since I just read that Mark is proposing to set the required Java base
>>> version to 8, I was wondering if this means there will be a 2.0 release
>>> that is Java 8ified. If so, I would like to propose to add this Pageable
>>> stuff to DeltaSpike Data 2.0.
>>>
>>> Comments, thoughts? :)
>>>
>>> --
>>>
>>> Mit freundlichen Grüßen,
>>> ------------------------------------------------------------------------
>>> *Christian Beikov*
>>>
>>>
>
Re: Introduce Pageable in DeltaSpike Data analogous to Spring Data
Posted by Christian Beikov <ch...@gmail.com>.
Ok great, I'll look into this.
As for JEE8, I'd prefer to keep JEE7 as the baseline for 2.0 as JEE8
doesn't seem to be very widespread yet.
Mit freundlichen Grüßen,
------------------------------------------------------------------------
*Christian Beikov*
Am 01.03.2018 um 10:16 schrieb Thomas Andraschko:
> Feel free to work on patch! ;)
>
> And yes, probably DS2.0 will need some redesigns or enhancements based on
> Java8.
> We also already talked about if DS2.0 should only target JEE8, to do a
> little cleanup on the project.
> I think we will need to start a new discussion, but don't know if anyone
> has time until TomEE8 is ready ;)
>
> 2018-03-01 9:30 GMT+01:00 Christian Beikov <ch...@gmail.com>:
>
>> Hey,
>>
>> I was wondering if there would be interest in introducing a Pageable
>> interface analogous to what Spring Data has or if the DeltaSpike answer to
>> this is the QueryResult interface.
>>
>> Being able to pass in the pagination configuration as parameter has the
>> advantage that one could e.g. write a JAX-RS RequestBodyReader for
>> constructing the object from various sources. Without such a Pageable
>> interface, users would have to map the request parameters manually to the
>> respective operations in a QueryResult which is quite repetitive and not
>> really allows for extensions. I implemented an extension for Spring Data
>> and Spring MVC that adds support for keyset pagination which is made easily
>> possible because I can just subclasss the Pageable interface of Spring Data
>> and handle the deserialization in a custom MethodArgumentResolver. I'd like
>> to do the same for DeltaSpike Data with JAX-RS which forces me to create my
>> own Pageable interface.
>>
>> Since I just read that Mark is proposing to set the required Java base
>> version to 8, I was wondering if this means there will be a 2.0 release
>> that is Java 8ified. If so, I would like to propose to add this Pageable
>> stuff to DeltaSpike Data 2.0.
>>
>> Comments, thoughts? :)
>>
>> --
>>
>> Mit freundlichen Grüßen,
>> ------------------------------------------------------------------------
>> *Christian Beikov*
>>
Re: Introduce Pageable in DeltaSpike Data analogous to Spring Data
Posted by Thomas Andraschko <an...@gmail.com>.
Feel free to work on patch! ;)
And yes, probably DS2.0 will need some redesigns or enhancements based on
Java8.
We also already talked about if DS2.0 should only target JEE8, to do a
little cleanup on the project.
I think we will need to start a new discussion, but don't know if anyone
has time until TomEE8 is ready ;)
2018-03-01 9:30 GMT+01:00 Christian Beikov <ch...@gmail.com>:
> Hey,
>
> I was wondering if there would be interest in introducing a Pageable
> interface analogous to what Spring Data has or if the DeltaSpike answer to
> this is the QueryResult interface.
>
> Being able to pass in the pagination configuration as parameter has the
> advantage that one could e.g. write a JAX-RS RequestBodyReader for
> constructing the object from various sources. Without such a Pageable
> interface, users would have to map the request parameters manually to the
> respective operations in a QueryResult which is quite repetitive and not
> really allows for extensions. I implemented an extension for Spring Data
> and Spring MVC that adds support for keyset pagination which is made easily
> possible because I can just subclasss the Pageable interface of Spring Data
> and handle the deserialization in a custom MethodArgumentResolver. I'd like
> to do the same for DeltaSpike Data with JAX-RS which forces me to create my
> own Pageable interface.
>
> Since I just read that Mark is proposing to set the required Java base
> version to 8, I was wondering if this means there will be a 2.0 release
> that is Java 8ified. If so, I would like to propose to add this Pageable
> stuff to DeltaSpike Data 2.0.
>
> Comments, thoughts? :)
>
> --
>
> Mit freundlichen Grüßen,
> ------------------------------------------------------------------------
> *Christian Beikov*
>