You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2020/09/08 20:13:00 UTC

[jira] [Commented] (CASSANDRA-16112) in-jvm dtests should validate Instance#serializeMessage serializeSize matches bytes written

    [ https://issues.apache.org/jira/browse/CASSANDRA-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192433#comment-17192433 ] 

David Capwell commented on CASSANDRA-16112:
-------------------------------------------

Added https://github.com/apache/cassandra/pull/741/commits/be42b5cf0f23aaaf07a5da158b3d40010be84039 in 3.0 and 3.11.  When talking to pre 3.0 ReadCommand forgot to include the table name in the size estimate

> in-jvm dtests should validate Instance#serializeMessage serializeSize matches bytes written
> -------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16112
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16112
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0-beta
>
>
> In 3.0 sizeOf is an optimization but in 4.0 its used for message header and as such must be correct; this check is not done when mock messaging is used so may ignore mixed-mode issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org