You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "AlbumenJ (via GitHub)" <gi...@apache.org> on 2024/03/08 02:09:09 UTC
[I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
AlbumenJ opened a new issue, #13856:
URL: https://github.com/apache/dubbo/issues/13856
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar feature requirement.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Descriptions
Service Discovery support local cache when registry is unavailable
### Related issues
_No response_
### Are you willing to submit a pull request to fix on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "ShauryaChauhan1411 (via GitHub)" <gi...@apache.org>.
ShauryaChauhan1411 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-3693905258
Hi @AlbumenJ, I'm Shaurya. I recently merged #15872 (Nacos Registry fix). I'm very interested in Service Discovery and would like to help implement the local cache support for when the registry is unavailable. May I be assigned to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "ghostly72 (via GitHub)" <gi...@apache.org>.
ghostly72 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-3694542606
Hi @ShauryaChauhan1411 . I've linked a PR to this issue, and im working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-1987054784
> What scenarios need this feature? In general, the registry sdk already supports local cache.
1. zookeeper not support
2. Nacos's local cache is not useful for Dubbo. Nacos will use local cache by highest priority, but Dubbo only want it as the fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-1991149968
> Hi, I am new to Dubbo community and willing to complete this task.
>
> Is there any restriction on this issue? For example, in terms of completion time and code quality.
1. We have no completion time limitation
2. For code quality, we have add a lot of checkers in Github Actions and we will check it when pull request reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2461699892
> I think I can solve this problem, please assign me~ @AlbumenJ
Please go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "MaxChen1123 (via GitHub)" <gi...@apache.org>.
MaxChen1123 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2690674090
@AlbumenJ For `org.apache.dubbo.registry.zookeeper.ZookeeperRegistry`, if we want Dubbo can start even if the `zkClient` cannot connect to Zookeeper server, we can just make the zkClient's initialization async (in this scenario, zkClient would be null ). So once the `doSubscribe` or `doRegister` is called, it will throw Exception, and the catch block in `org.apache.dubbo.registry.support.FailbackRegistry` will be executed, which will use the local cache in the disk. I've not tested the Nacos implement, but the solution may be the same.
But if we want to reconnect the registry continuously, do we need to retry all the failed call when finally connect to registry? Since FallbackRegistry already have the logic that will retry the failed call only once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "FAWC438 (via GitHub)" <gi...@apache.org>.
FAWC438 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-1994075461
Hi @AlbumenJ, I checked the relevant code and documentation, and I think the "local cache" mentioned in this issue actually refers to the consumer caching information such as the provider's `ip:port` obtained from the registry that is not down. Is that correct?
I did see the local caching function of `metadata` in the code, but as far as I know from reading the documentation, the metadata link maintained by Dubbo does not actually require the participation of the Service Discovery registry(Nacos or Zookeeper etc.), so does the work of this issue actually have nothing to do with `metadata` ?
And, regarding the implementation of local cache, since you mentioned that it will be used as a fallback solution, I think it only needs to be implemented in memory (for example, through a `Map` ) without the need to store it in the disk (like Nacos) , because it is a small probability event after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "dyx1234 (via GitHub)" <gi...@apache.org>.
dyx1234 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2454344350
I think I can solve this problem, please assign me~ @AlbumenJ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2134266464
> Hey, I want to help too, can you provide more detailed information? For example, what is the local specific information storage location and storage form. @AlbumenJ
You can check the related example in `org.apache.dubbo.registry.support.AbstractRegistry`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2571539451
> Looks like this issue is still unresolved. Please assign it to me.i will go ahead @AlbumenJ
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "ghostly72 (via GitHub)" <gi...@apache.org>.
ghostly72 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-3654979541
Hi @AlbumenJ , i added some code in `org.apache.dubbo.registry.support.AbstractRegistry` to read from the local cache when registry is not available and notify the consumer abt it.
submitted a pr as well
can u guys review it ? happy to get some suggestions on it
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "HeyAlaia (via GitHub)" <gi...@apache.org>.
HeyAlaia commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2283267165
If Dubbo cannot reconnect to the broken registry, this may be another problem. should open another issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "FAWC438 (via GitHub)" <gi...@apache.org>.
FAWC438 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-1987916869
Hi, I am new to Dubbo community and willing to complete this task.
Is there any restriction on this issue? For example, in terms of completion time and code quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "chiangzeon (via GitHub)" <gi...@apache.org>.
chiangzeon commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-3615897397
@AlbumenJ Hi, is this issue still unresolved? Could you please assign it to me? I'd like to have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "MaxChen1123 (via GitHub)" <gi...@apache.org>.
MaxChen1123 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2689883053
@AlbumenJ I found the `org.apache.dubbo.registry.support.FailbackRegistry` already have the function to use local cache when the `doSubscribe` method throws Exception. So, for the `org.apache.dubbo.registry.zookeeper.ZookeeperRegistry`, if user want to start Dubbo when Zookeeper crashes, we can just make the zkClient initialization async. Then `checkDestroyed()` in every `doSubscribe` call will throw Exception because `zkClient` is null, and then the local cache can be used. I've not tested the Nacos implement yet, but the solution may be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-1994145040
> And, regarding the implementation of local cache, since you mentioned that it will be used as a fallback solution, I think it only needs to be implemented in memory (for example, through a `Map` ) without the need to store it in the disk (like Nacos) , because it is a small probability event after all.
The main purpose is to save in the disk. To prevent if registry crashed Dubbo cannot start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "walkinggo (via GitHub)" <gi...@apache.org>.
walkinggo commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2087557883
> > And, regarding the implementation of local cache, since you mentioned that it will be used as a fallback solution, I think it only needs to be implemented in memory (for example, through a `Map` ) without the need to store it in the disk (like Nacos) , because it is a small probability event after all.
>
> The main purpose is to save in the disk. To prevent if registry crashed Dubbo cannot start.
Indeed, you can use serialization interfaces to save information on the local disk. However, if users tamper with the files storing this information, it can lead to data security issues. Unauthorized changes might corrupt the data, introduce errors, or cause security vulnerabilities if sensitive data is exposed or manipulated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "walkinggo (via GitHub)" <gi...@apache.org>.
walkinggo commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2143889563
I test it, and i find out that dubbo cannot work if registry is down.I can check it is true when registry is zookeeper or nacos.And also,i can see the `org.apache.dubbo.registry.support.AbstractRegistry` will store the local cache when `localCacheEnabled `is true.I think the way to finish it is read the local cache when the registry cannot be connected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "ghostly72 (via GitHub)" <gi...@apache.org>.
ghostly72 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-3732937899
so to detect only the case of registry failure, can we add another flag like `isRegistryDown` in abstract registry?
im thinking of maybr adding:
```
private volatile boolean registryDown = false;
protected boolean isRegistryDown() {
return registryDown;
}
protected void setRegistryDown(boolean down) {
this.registryDown = down;
}
```
and
```
private boolean isConnectionException(Throwable t) {
return t instanceof java.io.IOException
|| t instanceof java.net.ConnectException
|| t instanceof java.net.SocketTimeoutException
|| (t.getMessage() != null && t.getMessage().contains("Connection refused"));
// we can add other exceptions that correspond to the registry failure or unavailability scenario as well
}
```
inside abstract registry.
other registry implementatoins ultimately extend this.
so in every registry, we'll have code block similar to
```
try{
// register/unregister/subscriber/unsubscribe to registry
}catch{
// msg saying failed to connect due to some error
// here we can call isConnectionException and check if we should set the flag or not accordingly
```
and then finally inside abstractregistry's code
we can have
```
if(!isRegistryDown) enable local cache
```
thoughts anyone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "finefuture (via GitHub)" <gi...@apache.org>.
finefuture commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-1985318870
What scenarios need this feature? In general, the registry sdk already supports local cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "walkinggo (via GitHub)" <gi...@apache.org>.
walkinggo commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2133000615
Hey, I want to help too, can you provide more detailed information? For example, what is the local specific information storage location and storage form. @AlbumenJ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2144147542
> I test it, and i find out that dubbo cannot work if registry is down.I can check it is true when registry is zookeeper or nacos.And also,i can see the `org.apache.dubbo.registry.support.AbstractRegistry` will store the local cache when `localCacheEnabled `is true.I think the way to finish it is read the local cache when the registry cannot be connected.
Yep, you're right. BTW, we should make sure Dubbo will try to reconnect the broken registry continuously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "Anon2Tokyo (via GitHub)" <gi...@apache.org>.
Anon2Tokyo commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-5282183725
Hello, is there anyone else who is working on solving this issue? I can handle this issue myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "walkinggo (via GitHub)" <gi...@apache.org>.
walkinggo commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2136541472
Firstly,we should make the zookeeper support the local cache.Secondly,we should make the nacos implements the fallback.It's the all the tasks need to finish in this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2139216223
> Firstly,we should make the zookeeper support the local cache.Secondly,we should make the nacos implements the fallback.It's the all the tasks need to finish in this issue?
We can make it more common and not depend on the specific registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "walkinggo (via GitHub)" <gi...@apache.org>.
walkinggo commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2558820549
Looks like this issue is still unresolved. Please assign it to me.i will go ahead @AlbumenJ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "MaxChen1123 (via GitHub)" <gi...@apache.org>.
MaxChen1123 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-2678923356
@AlbumenJ Hi, is this issue still unresolved? Could you please assign it to me? I'd like to have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature] Service Discovery support local cache when registry is unavailable [dubbo]
Posted by "ghostly72 (via GitHub)" <gi...@apache.org>.
ghostly72 commented on issue #13856:
URL: https://github.com/apache/dubbo/issues/13856#issuecomment-3732930473
hi
right now, in the pr i created for this, my code goes like (inside abstractregistry.java)
```
if(localCacheEnabled && !isAvailable){
try{
List<URL> cached=getCacheUrls(url);
if(CollectionUtils.isNotEmpty(cached)){
listener.notify(cached);
logger.info("Registry unavailable or not yet ready. Loaded cached URLs for "+url.getServiceKey()+" : "+cached.size());
}
}catch(Throwable t){
logger.warn(INTERNAL_ERROR,"failed to load local cache","","Failed to load chached registry data for "+url,t);
throw t;
}
}
```
but this fails tests because i think `isAvailable()` returns false not only when the registry crashes, but also when:
-the registry hasn’t connected yet (say during startup)
-the client object is null (like in tests or mocks)
-the registry was shut down gracefully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org