You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/07/13 14:50:45 UTC
[GitHub] brooklyn-server pull request #256: Convert versions to OSGi format before pa...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-server/pull/256
Convert versions to OSGi format before passing them to the OSGi runtime.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-server fix/version-handling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/256.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #256
----
commit 72787ab39a05cad3f0045b4182ee073ad70f81df
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2016-07-13T14:50:16Z
Convert versions to OSGi format before passing them to the OSGi runtime.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #256: Convert versions to OSGi format before pa...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/256#discussion_r70653631
--- Diff: utils/common/src/main/java/org/apache/brooklyn/util/osgi/OsgiUtils.java ---
@@ -98,4 +101,97 @@ public static String getVersionedId(Bundle b) {
return Maybe.of(new VersionedName(parts[0], v));
}
+ public static String toOsgiVersion(String version) {
--- End diff --
Worth adding a test that demonstrates the behaviour (even though the code is copy-pasted). I'd also like to see that a version such as `0.10.0-20160713.1653` is converted to `0.10.0.20160713_1653`. Note the last dot is converted to an underscore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #256: Convert versions to OSGi format before pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---