You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/02/04 17:47:38 UTC
[kudu-CR] Fix wrong substitute argument in ksck
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12352
Change subject: Fix wrong substitute argument in ksck
......................................................................
Fix wrong substitute argument in ksck
0355d373a7 used the wrong substitute argument, producing messages like
Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' replicas' active configs disagree with the master's
instead of
Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: 2 replicas' active configs disagree with the master's
This fixes the error.
Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
---
M src/kudu/tools/ksck.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/12352/1
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12352/2/src/kudu/tools/ksck-test.cc
File src/kudu/tools/ksck-test.cc:
http://gerrit.cloudera.org:8080/#/c/12352/2/src/kudu/tools/ksck-test.cc@1288
PS2, Line 1288: const string err_str = err_stream_.str();
Thanks for adding a test for that!
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 18:01:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Mitch Barnett, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12352
to look at the new patch set (#2).
Change subject: Fix wrong substitute argument in ksck
......................................................................
Fix wrong substitute argument in ksck
0355d373a7 used the wrong substitute argument, producing messages like
Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' replicas' active configs disagree with the master's
instead of
Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: 2 replicas' active configs disagree with the master's
This fixes the error and adds a bit of test code to keep it from
happening again.
Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/12352/2
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12352/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12352/1//COMMIT_MSG@11
PS1, Line 11: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' replicas' active configs disagree with the master's
nit: wrap lines
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 17:53:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12352/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12352/1//COMMIT_MSG@11
PS1, Line 11: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' replicas' active configs disagree with the master's
> nit: wrap lines
I don't wrap when I'm verbatim quoting logs or output.
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 17:59:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 18:01:24 +0000
Gerrit-HasComments: No
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Mitch Barnett (Code Review)" <ge...@cloudera.org>.
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 17:50:14 +0000
Gerrit-HasComments: No
[kudu-CR] Fix wrong substitute argument in ksck
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12352 )
Change subject: Fix wrong substitute argument in ksck
......................................................................
Fix wrong substitute argument in ksck
0355d373a7 used the wrong substitute argument, producing messages like
Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' replicas' active configs disagree with the master's
instead of
Tablet 7502f27f91d04070854a86dd62a204f9 of table 'foo' is conflicted: 2 replicas' active configs disagree with the master's
This fixes the error and adds a bit of test code to keep it from
happening again.
Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Reviewed-on: http://gerrit.cloudera.org:8080/12352
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90692a50e1abac8f7ddb5cac11a6bf6914457fe2
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <mb...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>