You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/05 05:36:56 UTC
[GitHub] [flink-kubernetes-operator] haoxins opened a new pull request, #292: Change the validator to return an error if the Jar URI is an empty string
haoxins opened a new pull request, #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292
This error may happen if I use Golang to submit the job with some bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #292: [FLINK-28385] Change the validator to return an error if the Jar URI is an empty string
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292#discussion_r913443188
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -178,7 +178,7 @@ private Optional<String> validateJobSpec(
return Optional.empty();
}
- if (job.getJarURI() == null) {
+ if (job.getJarURI() == null || job.getJarURI().equals("")) {
Review Comment:
This condition in this `if` check could be replaced by `StringUtils.isEmpty(job.getJarURI())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] haoxins commented on pull request #292: [FLINK-28385] Change the validator to return an error if the Jar URI is an empty string
Posted by GitBox <gi...@apache.org>.
haoxins commented on PR #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292#issuecomment-1175053628
is this enough?
https://github.com/apache/flink-kubernetes-operator/pull/292/files#diff-f1c88bf72a09bac9317bf7bbbb05037d87ad6fc36b04d2beba7558e5a3830b01R79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #292: [FLINK-28385] Change the validator to return an error if the Jar URI is an empty string
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292#issuecomment-1175035404
Thanks @haoxins. Could you please add a simple test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #292: [FLINK-28385] Change the validator to return an error if the Jar URI is an empty string
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] haoxins commented on a diff in pull request #292: [FLINK-28385] Change the validator to return an error if the Jar URI is an empty string
Posted by GitBox <gi...@apache.org>.
haoxins commented on code in PR #292:
URL: https://github.com/apache/flink-kubernetes-operator/pull/292#discussion_r913449561
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -178,7 +178,7 @@ private Optional<String> validateJobSpec(
return Optional.empty();
}
- if (job.getJarURI() == null) {
+ if (job.getJarURI() == null || job.getJarURI().equals("")) {
Review Comment:
`isEmpty` not found, using `isNullOrWhitespaceOnly` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org