You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/21 12:41:53 UTC

[GitHub] [pulsar] jianyun8023 commented on pull request #7874: add java8 date and time type to pulsar's primitive schemas

jianyun8023 commented on pull request #7874:
URL: https://github.com/apache/pulsar/pull/7874#issuecomment-678270022


   > @jianyun8023 When you update the PulsarApi.proto, you need also to push the generated java file. To generate the new java file, you can run `./pulsar-common/generate_protobuf_docker.sh`.
   > 
   > 
   > 
   > And please add unit test for the new schema type to ensure encoding and decoding are works well.
   > 
   > 
   > 
   > 
   
   
   Ok thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org