You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "RocMarshal (via GitHub)" <gi...@apache.org> on 2025/12/09 03:49:48 UTC

Re: [PR] [Connector/JDBC] Support passing arbitrary database options to JDBC Catalog [flink-connector-jdbc]

RocMarshal commented on code in PR #183:
URL: https://github.com/apache/flink-connector-jdbc/pull/183#discussion_r2600984414


##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/JdbcConnectionOptions.java:
##########
@@ -34,6 +34,7 @@ public class JdbcConnectionOptions implements Serializable {
 
     public static final String USER_KEY = "user";
     public static final String PASSWORD_KEY = "password";
+    public static final String DATABASE_OPTIONS = "database-options";

Review Comment:
   Thanks @och5351 for sorting out the previous related works and initiating the PR.
   
   Hi, @eskabetxe for your previous comment[1].
   
   I personally prefer passing parameters based on the baseUrl[2], for a few simple reasons:
   - Using the baseUrl to pass parameters can also achieve the current functionality.
   - Using the baseUrl to pass parameters avoids introducing new additional parameters, preserving the original style of the URL as much as possible. From a user’s perspective, there is no need to write an extra line of parameters.
   
   If using URL-based parameter passing across various database products fails to meet the current needs, then introducing db-options would be a good alternative.
   
   CC @snuyanzin 
   
   [1] https://github.com/apache/flink-connector-jdbc/pull/83#issuecomment-1857519079
   [2] https://github.com/apache/flink-connector-jdbc/pull/83
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org