You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/03 06:03:14 UTC

[GitHub] [incubator-dubbo] codecov-io commented on issue #3118: code optimization

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=h1) Report
> Merging [#3118](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/95ebfe8b5a93942d3c3928ad5e9cd4709c76886a?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `44.82%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##             master   #3118      +/-   ##
===========================================
- Coverage     63.67%   63.6%   -0.07%     
  Complexity       75      75              
===========================================
  Files           652     652              
  Lines         28190   28196       +6     
  Branches       4784    4784              
===========================================
- Hits          17950   17935      -15     
- Misses         7989    8006      +17     
- Partials       2251    2255       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh) | `69.35% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/rpc/cluster/router/AbstractRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyLmphdmE=) | `40% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/zookeeper/support/AbstractZookeeperClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvc3VwcG9ydC9BYnN0cmFjdFpvb2tlZXBlckNsaWVudC5qYXZh) | `77.41% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...o/metadata/definition/model/ServiceDefinition.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vbW9kZWwvU2VydmljZURlZmluaXRpb24uamF2YQ==) | `44.82% <0%> (-3.33%)` | `9 <0> (ø)` | |
| [...ubbo/metadata/definition/model/TypeDefinition.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vbW9kZWwvVHlwZURlZmluaXRpb24uamF2YQ==) | `30% <0%> (-1.58%)` | `7 <0> (ø)` | |
| [...bo/metadata/definition/model/MethodDefinition.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLWRlZmluaXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL2RlZmluaXRpb24vbW9kZWwvTWV0aG9kRGVmaW5pdGlvbi5qYXZh) | `39.28% <0%> (-3.03%)` | `8 <0> (ø)` | |
| [...e/dubbo/rpc/cluster/directory/StaticDirectory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZGlyZWN0b3J5L1N0YXRpY0RpcmVjdG9yeS5qYXZh) | `66.66% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtSW52b2tlci5qYXZh) | `84.61% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `79.09% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `58.27% <100%> (-0.76%)` | `0 <0> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3118/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=footer). Last update [95ebfe8...e4ef2c7](https://codecov.io/gh/apache/incubator-dubbo/pull/3118?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3118 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org