[GitHub] [iceberg] flyrain edited a comment on pull request #2965: Core: rename WRITE_NEW_DATA_LOCATION to WRITE_FOLDER_STORAGE_LOCATION

[GitBox <gi...@apache.org>]

flyrain edited a comment on pull request #2965:
URL: https://github.com/apache/iceberg/pull/2965#issuecomment-902236323


   > 3. in a subsequent PR, we can deprecate `write.object-storage.path` and only have 1 overwrite config.
   > 
   > For 3, my thinking is to avoid the need to introduce yet another config key, although I understand the name `write.folder-storage.path` isn't really ideal. Ideally we can have `write.data.path` which parallels `write.metadata.path`, but I really don't want to introduce yet another variable. What's your thoughts on this?
   
   Nice plan! I like the name `write.data.path`, but `write.folder-storage.path` is fine since it is there for a while. We can bring it up in the next community sync-up. We can go with `write.data.path` if there aren't many users using `write.folder-storage.path`.
   
   Also let us know if you don't have time for step 3, we are glad to help. Thanks @jackye1995!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org