You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2024/10/15 13:03:30 UTC
[PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
weizhouapache opened a new pull request, #9799:
URL: https://github.com/apache/cloudstack/pull/9799
### Description
This PR fixes #9797
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2418308882
<b>[SF] Trillian test result (tid-11667)</b>
Environment: kvm-ol9 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 64695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11667-kvm-ol9.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 272.88 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 272.90 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2419003947
LGTM, tests & review LGTM. Only affects deb packaging that too installation of a required dependency on Ubuntu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2418639955
this is ready for review
the smoke test results look fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415929388
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2418114547
<b>[SF] Trillian test result (tid-11670)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54498 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11670-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415898796
@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2418119713
<b>[SF] Trillian test result (tid-11673)</b>
Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24
Total time taken: 53141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11673-kvm-ubuntu24.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_enable_ha_when_host_disabled | `Error` | 4.00 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 302.04 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2413893436
> @weizhouapache this was spoted only for Ubuntu 22.04+, not sure if EL8 are affected
@andrijapanicsb
the package name is the same on ubuntu 22/24 and el8/9
it is a known issue (for me yes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2414006370
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9799?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 16.60%. Comparing base [(`f10d9fe`)](https://app.codecov.io/gh/apache/cloudstack/commit/f10d9fecbe84d39b33ef6e3b4de8a9e4ce645759?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`559cff4`)](https://app.codecov.io/gh/apache/cloudstack/commit/559cff49022f3dae9e677c753c7ddfe148d32d8d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9799 +/- ##
============================================
- Coverage 16.60% 16.60% -0.01%
- Complexity 12564 12565 +1
============================================
Files 5235 5235
Lines 460088 460088
Branches 58295 54475 -3820
============================================
- Hits 76408 76406 -2
- Misses 375354 375355 +1
- Partials 8326 8327 +1
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9799/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9799/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.60% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9799?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2418056283
<b>[SF] Trillian test result (tid-11669)</b>
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 51942 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11669-kvm-debian12.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415762689
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415895468
@blueorangutan test ol9 kvm-ol9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415985667
<b>[SF] Trillian Build Failed (tid-11668)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2413867204
@weizhouapache this was spoted only for Ubuntu 22.04+, not sure if EL8 are affected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415871756
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2416007305
kicked off tests on
- ol8
- ol9
- ubuntu24
- debian12
let's wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415760195
@weizhouapache is this considered critical for 4.20 release? cc @JoaoJandre
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #9799:
URL: https://github.com/apache/cloudstack/pull/9799#issuecomment-2415928414
@blueorangutan test ol8 kvm-ol8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org