You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Will Stevens <ws...@cloudops.com> on 2013/10/29 21:23:47 UTC
Review Request 15047: Add support for multiple networks in the 'per account'
source nat type setting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15047/
-----------------------------------------------------------
Review request for cloudstack and Sheng Yang.
Bugs: CLOUDSTACK-4991
https://issues.apache.org/jira/browse/CLOUDSTACK-4991
Repository: cloudstack-git
Description
-------
Patch to fix: https://issues.apache.org/jira/browse/CLOUDSTACK-4991
Please review the attached PDF and the issue and contact me if anything is unclear.
Diffs
-----
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 629bef5
Diff: https://reviews.apache.org/r/15047/diff/
Testing
-------
I have been using this patch for 3 months without issues.
File Attachments
----------------
Email thread from mailing list
https://reviews.apache.org/media/uploaded/files/2013/10/29/Supported_Source_NAT_Type.pdf
Thanks,
Will Stevens
Re: Review Request 15047: Add support for multiple networks in the 'per
account' source nat type setting
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15047/#review27795
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On Oct. 29, 2013, 8:24 p.m., Will Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15047/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 8:24 p.m.)
>
>
> Review request for cloudstack and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-4991
> https://issues.apache.org/jira/browse/CLOUDSTACK-4991
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Patch to fix: https://issues.apache.org/jira/browse/CLOUDSTACK-4991
>
> Please review the attached PDF and the issue and contact me if anything is unclear.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 629bef5
>
> Diff: https://reviews.apache.org/r/15047/diff/
>
>
> Testing
> -------
>
> I have been using this patch for 3 months without issues.
>
>
> File Attachments
> ----------------
>
> Email thread from mailing list
> https://reviews.apache.org/media/uploaded/files/2013/10/29/Supported_Source_NAT_Type.pdf
>
>
> Thanks,
>
> Will Stevens
>
>
Re: Review Request 15047: Add support for multiple networks in the 'per
account' source nat type setting
Posted by Will Stevens <ws...@cloudops.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15047/
-----------------------------------------------------------
(Updated Oct. 29, 2013, 8:24 p.m.)
Review request for cloudstack and Sheng Yang.
Bugs: CLOUDSTACK-4991
https://issues.apache.org/jira/browse/CLOUDSTACK-4991
Repository: cloudstack-git
Description
-------
Patch to fix: https://issues.apache.org/jira/browse/CLOUDSTACK-4991
Please review the attached PDF and the issue and contact me if anything is unclear.
Diffs
-----
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 629bef5
Diff: https://reviews.apache.org/r/15047/diff/
Testing
-------
I have been using this patch for 3 months without issues.
File Attachments
----------------
Email thread from mailing list
https://reviews.apache.org/media/uploaded/files/2013/10/29/Supported_Source_NAT_Type.pdf
Thanks,
Will Stevens